From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3v0VtY18LyzDqRp for ; Sat, 14 Jan 2017 05:06:13 +1100 (AEDT) Date: Fri, 13 Jan 2017 19:06:02 +0100 From: Christoph Hellwig To: Kishon Vijay Abraham I Cc: Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, nsekhar@ti.com Subject: Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions Message-ID: <20170113180602.GA30346@infradead.org> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1484216786-17292-17-git-send-email-kishon@ti.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Kishon, a couple comments on the configfs layout based on my experiments with your previous drop to implement a NVMe device using it. I don't think most of these configfs files should be present here, as they are properties of the implemented PCIe devices. E.g. for my NVMe device they will be sort of hardcoded most of the time, as they would be for other devices that would always have a fixed vendor/device/ class ID, cacheline size, etc. In the end what we'll to be able to do here is to be able to create a directory for each function driver, which then can create it's own attributes inside it.