From: David Daney <david.daney@cavium.com>
To: Jason Baron <jbaron@akamai.com>,
Steven Rostedt <rostedt@goodmis.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Sachin Sant <sachinp@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
Chris Metcalf <cmetcalf@mellanox.com>,
Ralf Baechle <ralf@linux-mips.org>,
Russell King <linux@armlinux.org.uk>,
Rabin Vincent <rabin@rab.in>, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>, Ingo Molnar <mingo@kernel.org>,
Zhigang Lu <zlu@ezchip.com>, David Daney <david.daney@cavium.com>
Subject: [PATCH] module: set __jump_table alignment to 8
Date: Wed, 1 Mar 2017 14:04:53 -0800 [thread overview]
Message-ID: <20170301220453.4756-1-david.daney@cavium.com> (raw)
For powerpc the __jump_table section in modules is not aligned, this
causes a WARN_ON() splat when loading a module containing a __jump_table.
Strict alignment became necessary with commit 3821fd35b58d
("jump_label: Reduce the size of struct static_key"), currently in
linux-next, which uses the two least significant bits of pointers to
__jump_table elements.
Fix by forcing __jump_table to 8, which is the same alignment used for
this section in the kernel proper.
Signed-off-by: David Daney <david.daney@cavium.com>
Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
---
scripts/module-common.lds | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/module-common.lds b/scripts/module-common.lds
index 73a2c7d..53234e8 100644
--- a/scripts/module-common.lds
+++ b/scripts/module-common.lds
@@ -19,4 +19,6 @@ SECTIONS {
. = ALIGN(8);
.init_array 0 : { *(SORT(.init_array.*)) *(.init_array) }
+
+ __jump_table 0 : ALIGN(8) { KEEP(*(__jump_table)) }
}
--
2.9.3
next reply other threads:[~2017-03-01 22:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 22:04 David Daney [this message]
2017-03-02 10:47 ` [PATCH] module: set __jump_table alignment to 8 Michael Ellerman
2017-03-02 11:18 ` Michael Ellerman
2017-03-02 17:44 ` Steven Rostedt
2017-03-03 3:34 ` Michael Ellerman
2017-03-02 15:30 ` Jason Baron
2017-03-02 18:11 ` Steven Rostedt
2017-03-02 18:26 ` Jessica Yu
2017-03-02 19:24 ` David Daney
2017-03-02 22:49 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301220453.4756-1-david.daney@cavium.com \
--to=david.daney@cavium.com \
--cc=anton@samba.org \
--cc=cmetcalf@mellanox.com \
--cc=jbaron@akamai.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rabin@rab.in \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=zlu@ezchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).