From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Anton Blanchard <anton@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: kprobes: convert __kprobes to NOKPROBE_SYMBOL()
Date: Wed, 8 Mar 2017 15:37:29 +0530 [thread overview]
Message-ID: <20170308100729.GG11046@naverao1-tp.localdomain> (raw)
In-Reply-To: <20170308094245.ace4eeff69b79d1956a277ee@kernel.org>
On 2017/03/08 09:42AM, Masami Hiramatsu wrote:
> On Wed, 8 Mar 2017 02:09:29 +0530
> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
>
> > Along similar lines as commit 9326638cbee2 ("kprobes, x86: Use
> > NOKPROBE_SYMBOL() instead of __kprobes annotation"), convert __kprobes
> > annotation to either NOKPROBE_SYMBOL() or nokprobe_inline. The latter
> > forces inlining, in which case the caller needs to be added to
> > NOKPROBE_SYMBOL().
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> OK, this is a good starting point so far. please consider that those
> functions really have to be protected by kprobes. As you can see on x86,
Yes, I've only converted static functions to nokprobe_inline and
confirmed that their callers are protected. I also verified that none of
these show up in kallsyms.
> I allowed some functions to be kprobed by commit 7ec8a97a990d ("kprobes/x86:
> Allow probe on some kprobe preparation functions").
> Maybe on powerpc, those arch_* functions also be probed safely, since
> those are not kicked in the context of breakpoint interruption.
Nice, thanks for the pointer. I will consider that as part of the kprobe
blacklisting updates I have for powerpc.
Regards,
Naveen
prev parent reply other threads:[~2017-03-08 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 20:39 [PATCH] powerpc: kprobes: convert __kprobes to NOKPROBE_SYMBOL() Naveen N. Rao
2017-03-08 8:42 ` Masami Hiramatsu
2017-03-08 10:07 ` Naveen N. Rao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308100729.GG11046@naverao1-tp.localdomain \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhiramat@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).