From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
alsa-devel@alsa-project.org, Timur Tabi <timur@tabi.org>,
Xiubo.Lee@gmail.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup
Date: Tue, 28 Mar 2017 16:24:57 +0100 [thread overview]
Message-ID: <20170328152457.2j5zaxdbdavpuspa@sirena.org.uk> (raw)
In-Reply-To: <20170328115306.GR6986@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote:
> On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote:
> > >> - codec_clk = devm_clk_get(&codec_dev->dev, NULL);
> > >> + codec_clk = clk_get(&codec_dev->dev, NULL);
> > is different from &codec_dev->dev.
> I get that they are different, I just don't get why changing
> from a devm_clk_get to a clk_get is a better fix than changing
> &codec->dev to &pdev->dev.
This should be clear from the semantics of clk_get(): you're looking up
the clock in the context of the supplied device and the clock is
attached to the CODEC so you need to look up in the CODEC context. What
would be even better would be to move the allocation of the clock into
the CODEC driver...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-03-28 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:58 [PATCH v3 0/2] imx-wm8962: Let codec driver enable/disable its MCLK Daniel Baluta
2017-03-28 8:58 ` [PATCH v3 1/2] ASoC: " Daniel Baluta
2017-03-28 8:58 ` [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Daniel Baluta
2017-03-28 9:21 ` [alsa-devel] " Charles Keepax
2017-03-28 10:47 ` Daniel Baluta
2017-03-28 11:53 ` Charles Keepax
2017-03-28 15:24 ` Mark Brown [this message]
2017-03-28 15:42 ` Charles Keepax
2017-03-29 11:38 ` Daniel Baluta
2017-03-29 11:47 ` Mark Brown
2017-03-29 11:54 ` Applied "ASoC: imx-wm8962: Fix codec_clk cleanup" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328152457.2j5zaxdbdavpuspa@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).