From: David Miller <davem@davemloft.net>
To: madalin.bucur@nxp.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] dpaa_eth: add NETIF_F_RXHASH
Date: Mon, 21 Aug 2017 10:57:06 -0700 (PDT) [thread overview]
Message-ID: <20170821.105706.646457120423300952.davem@davemloft.net> (raw)
In-Reply-To: <1503046588-24349-5-git-send-email-madalin.bucur@nxp.com>
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Fri, 18 Aug 2017 11:56:26 +0300
> + if (net_dev->features & NETIF_F_RXHASH && priv->keygen_in_use &&
> + !fman_port_get_hash_result_offset(priv->mac_dev->port[RX],
> + &hash_offset))
> + skb_set_hash(skb, be32_to_cpu(*(u32 *)(vaddr + hash_offset)),
> + // if L4 exists, it was used in the hash generation
> + be32_to_cpu(fd->status) & FM_FD_STAT_L4CV ?
> + PKT_HASH_TYPE_L4 : PKT_HASH_TYPE_L3);
We do not use "//" c++ style comments in the kernel.
And putting a comment right in the middle of a set of arguments being
passed to a function makes the code harder to read, so please do not
do this.
next prev parent reply other threads:[~2017-08-21 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 8:56 [PATCH 0/6] Add RSS to DPAA 1.x Ethernet driver Madalin Bucur
2017-08-18 8:56 ` [PATCH 1/6] fsl/fman: enable FMan Keygen Madalin Bucur
2017-08-18 8:56 ` [PATCH 2/6] dpaa_eth: use multiple Rx frame queues Madalin Bucur
2017-08-18 8:56 ` [PATCH 3/6] dpaa_eth: enable Rx hashing control Madalin Bucur
2017-08-18 8:56 ` [PATCH 4/6] dpaa_eth: add NETIF_F_RXHASH Madalin Bucur
2017-08-21 17:57 ` David Miller [this message]
2017-08-18 8:56 ` [PATCH 5/6] Documentation: networking: add RSS information Madalin Bucur
2017-08-18 8:56 ` [PATCH 6/6] dpaa_eth: check allocation result Madalin Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821.105706.646457120423300952.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).