From: "Michal Suchánek" <msuchanek@suse.de>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linuxppc-dev@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeremy Kerr <jk@ozlabs.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions
Date: Thu, 5 Oct 2017 22:02:10 +0200 [thread overview]
Message-ID: <20171005220210.681f78e8@kitsune.suse.cz> (raw)
In-Reply-To: <62146108-5be0-c236-f404-4be122e162ac@users.sourceforge.net>
Hello,
On Thu, 5 Oct 2017 21:36:26 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 5 Oct 2017 21:04:30 +0200
>
> Omit extra messages for a memory allocation failure in these
> functions.
this is bogus. All these functions return -1 on any error. Until they
reflect the error in their return value (and it is properly propagated
to the user) there is no way to tell WTF failed without the message.
>
> This issue was detected by using the Coccinelle software.
>
... which provides only a hint which should be evaluated by the user.
Thanks
Michal
next prev parent reply other threads:[~2017-10-05 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 19:34 [PATCH 0/2] PowerPC-Cell platform: Adjustments for four function implementations SF Markus Elfring
2017-10-05 19:36 ` [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2017-10-05 20:02 ` Michal Suchánek [this message]
2017-10-05 20:06 ` Julia Lawall
2017-10-05 20:29 ` Michal Suchánek
2017-10-06 2:02 ` Joe Perches
2017-10-05 19:38 ` [PATCH 2/2] powerpc/platforms/cell: Improve a size determination " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005220210.681f78e8@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=elfring@users.sourceforge.net \
--cc=jk@ozlabs.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).