From: jglisse@redhat.com
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
"Jérôme Glisse" <jglisse@redhat.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Joerg Roedel" <jroedel@suse.de>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Alistair Popple" <alistair@popple.id.au>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Andrew Donnellan" <andrew.donnellan@au1.ibm.com>,
iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 0/2] Optimize mmu_notifier->invalidate_range callback
Date: Mon, 16 Oct 2017 23:10:01 -0400 [thread overview]
Message-ID: <20171017031003.7481-1-jglisse@redhat.com> (raw)
From: Jérôme Glisse <jglisse@redhat.com>
(Andrew you already have v1 in your queue of patch 1, patch 2 is new,
i think you can drop it patch 1 v1 for v2, v2 is bit more conservative
and i fixed typos)
All this only affect user of invalidate_range callback (at this time
CAPI arch/powerpc/platforms/powernv/npu-dma.c, IOMMU ATS/PASID in
drivers/iommu/amd_iommu_v2.c|intel-svm.c)
This patchset remove useless double call to mmu_notifier->invalidate_range
callback wherever it is safe to do so. The first patch just remove useless
call and add documentation explaining why it is safe to do so. The second
patch go further by introducing mmu_notifier_invalidate_range_only_end()
which skip callback to invalidate_range this can be done when clearing a
pte, pmd or pud with notification which call invalidate_range right after
clearing under the page table lock.
It should improve performances but i am lacking hardware and benchmarks
which might show an improvement. Maybe folks in cc can help here.
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Alistair Popple <alistair@popple.id.au>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Cc: iommu@lists.linux-foundation.org
Cc: linuxppc-dev@lists.ozlabs.org
Jérôme Glisse (2):
mm/mmu_notifier: avoid double notification when it is useless v2
mm/mmu_notifier: avoid call to invalidate_range() in range_end()
Documentation/vm/mmu_notifier.txt | 93 +++++++++++++++++++++++++++++++++++++++
fs/dax.c | 9 +++-
include/linux/mmu_notifier.h | 20 +++++++--
mm/huge_memory.c | 66 ++++++++++++++++++++++++---
mm/hugetlb.c | 16 +++++--
mm/ksm.c | 15 ++++++-
mm/memory.c | 6 ++-
mm/migrate.c | 15 +++++--
mm/mmu_notifier.c | 11 ++++-
mm/rmap.c | 59 ++++++++++++++++++++++---
10 files changed, 281 insertions(+), 29 deletions(-)
create mode 100644 Documentation/vm/mmu_notifier.txt
--
2.13.6
next reply other threads:[~2017-10-17 3:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 3:10 jglisse [this message]
2017-10-17 3:10 ` [PATCH 1/2] mm/mmu_notifier: avoid double notification when it is useless v2 jglisse
2017-10-19 3:04 ` Balbir Singh
2017-10-19 3:28 ` Jerome Glisse
2017-10-19 10:53 ` Balbir Singh
2017-10-19 16:58 ` Jerome Glisse
2017-10-21 5:54 ` Balbir Singh
2017-10-21 15:47 ` Jerome Glisse
2017-10-23 20:35 ` Jerome Glisse
2017-10-17 3:10 ` [PATCH 2/2] mm/mmu_notifier: avoid call to invalidate_range() in range_end() jglisse
2017-10-19 2:43 ` [PATCH 0/2] Optimize mmu_notifier->invalidate_range callback Balbir Singh
2017-10-19 3:08 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017031003.7481-1-jglisse@redhat.com \
--to=jglisse@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sfr@canb.auug.org.au \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).