From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Christophe Leroy <christophe.leroy@c-s.fr>
Subject: [RFC PATCH 0/5] powerpc/mm/slice: improve slice speed and stack use
Date: Sat, 10 Feb 2018 18:11:34 +1000 [thread overview]
Message-ID: <20180210081139.27236-1-npiggin@gmail.com> (raw)
This series intends to improve performance and reduce stack
consumption in the slice allocation code. It does it by keeping slice
masks in the mm_context rather than compute them for each allocation,
and by reducing bitmaps and slice_masks from stacks, using pointers
instead where possible.
checkstack.pl gives, before:
0x00000de4 slice_get_unmapped_area [slice.o]: 656
0x00001b4c is_hugepage_only_range [slice.o]: 512
0x0000075c slice_find_area_topdown [slice.o]: 416
0x000004c8 slice_find_area_bottomup.isra.1 [slice.o]: 272
0x00001aa0 slice_set_range_psize [slice.o]: 240
0x00000a64 slice_find_area [slice.o]: 176
0x00000174 slice_check_fit [slice.o]: 112
after:
0x00000d70 slice_get_unmapped_area [slice.o]: 320
0x000008f8 slice_find_area [slice.o]: 144
0x00001860 slice_set_range_psize [slice.o]: 144
0x000018ec is_hugepage_only_range [slice.o]: 144
0x00000750 slice_find_area_bottomup.isra.4 [slice.o]: 128
The benchmark in https://github.com/linuxppc/linux/issues/49 gives, before:
$ time ./slicemask
real 0m20.712s
user 0m5.830s
sys 0m15.105s
after:
$ time ./slicemask
real 0m13.197s
user 0m5.409s
sys 0m7.779s
Thanks,
Nick
Nicholas Piggin (5):
powerpc/mm/slice: pass pointers to struct slice_mask where possible
powerpc/mm/slice: implement a slice mask cache
powerpc/mm/slice: implement slice_check_range_fits
powerpc/mm/slice: Use const pointers to cached slice masks where
possible
powerpc/mm/slice: use the dynamic high slice size to limit bitmap
operations
arch/powerpc/include/asm/book3s/64/mmu.h | 20 +-
arch/powerpc/mm/slice.c | 302 +++++++++++++++++++------------
2 files changed, 204 insertions(+), 118 deletions(-)
--
2.15.1
next reply other threads:[~2018-02-10 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 8:11 Nicholas Piggin [this message]
2018-02-10 8:11 ` [RFC PATCH 1/5] powerpc/mm/slice: pass pointers to struct slice_mask where possible Nicholas Piggin
2018-02-10 8:11 ` [RFC PATCH 2/5] powerpc/mm/slice: implement a slice mask cache Nicholas Piggin
2018-02-10 8:11 ` [RFC PATCH 3/5] powerpc/mm/slice: implement slice_check_range_fits Nicholas Piggin
2018-02-10 8:11 ` [RFC PATCH 4/5] powerpc/mm/slice: Use const pointers to cached slice masks where possible Nicholas Piggin
2018-02-10 8:11 ` [RFC PATCH 5/5] powerpc/mm/slice: use the dynamic high slice size to limit bitmap operations Nicholas Piggin
2018-02-12 15:02 ` [RFC PATCH 0/5] powerpc/mm/slice: improve slice speed and stack use Christophe LEROY
2018-02-12 15:24 ` Nicholas Piggin
2018-02-12 17:42 ` Christophe LEROY
2018-02-13 8:40 ` Nicholas Piggin
2018-02-13 11:24 ` Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180210081139.27236-1-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).