linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bharat Bhushan <Bharat.Bhushan@nxp.com>
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
	oss@buserror.net, galak@kernel.crashing.org,
	mark.rutland@arm.com, kstewart@linuxfoundation.org,
	gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	keescook@chromium.org, tyreld@linux.vnet.ibm.com,
	joe@perches.com
Subject: Re: [RFC 3/5] powerpc/mpic: Add support for non-contiguous irq ranges
Date: Tue, 7 Aug 2018 12:09:38 -0600	[thread overview]
Message-ID: <20180807180938.GA13623@rob-hp-laptop> (raw)
In-Reply-To: <1532684881-19310-4-git-send-email-Bharat.Bhushan@nxp.com>

On Fri, Jul 27, 2018 at 03:17:59PM +0530, Bharat Bhushan wrote:
> Freescale MPIC h/w may not support all interrupt sources reported
> by hardware, "last-interrupt-source" or platform. On these platforms
> a misconfigured device tree that assigns one of the reserved
> interrupts leaves a non-functioning system without warning.

There are lots of ways to misconfigure DTs. I don't think this is 
special and needs a property. We've had some interrupt mask or valid 
properties in the past, but generally don't accept those.

> 
> This patch adds "supported-irq-ranges" property in device tree to
> provide the range of supported source of interrupts. If a reserved
> interrupt used then it will not be programming h/w, which it does
> currently, and through warning.
> 
> Signed-off-by: Bharat Bhushan <Bharat.Bhushan@nxp.com>
> ---
>  .../devicetree/bindings/powerpc/fsl/mpic.txt       |   8 ++
>  arch/powerpc/include/asm/mpic.h                    |   9 ++
>  arch/powerpc/sysdev/mpic.c                         | 113 +++++++++++++++++++--
>  3 files changed, 121 insertions(+), 9 deletions(-)

  reply	other threads:[~2018-08-07 18:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  9:47 [RFC 0/5] powerpc/mpic: Add non-contiguous interrupt sources Bharat Bhushan
2018-07-27  9:47 ` [RFC 1/5] powerpc/mpic: move last irq logic to function Bharat Bhushan
2018-07-27  9:47 ` [RFC 2/5] powerpc/mpic: Rework last source irq calculation logic Bharat Bhushan
2018-07-27  9:47 ` [RFC 3/5] powerpc/mpic: Add support for non-contiguous irq ranges Bharat Bhushan
2018-08-07 18:09   ` Rob Herring [this message]
2018-08-07 21:03     ` Scott Wood
2018-08-08  3:37       ` Bharat Bhushan
2018-08-08  5:50         ` Scott Wood
2018-08-08  5:57           ` Bharat Bhushan
2018-07-27  9:48 ` [RFC 4/5] powerpc/mpic: Boot print supported interrupt ranges Bharat Bhushan
2018-07-27  9:48 ` [RFC 5/5] powerpc/fsl: Add supported-irq-ranges for P2020 Bharat Bhushan
2018-08-07 21:13   ` Scott Wood
2018-08-08  3:44     ` Bharat Bhushan
2018-08-08  5:55       ` Scott Wood
2018-08-08  6:28         ` Bharat Bhushan
2018-08-08 17:57           ` Scott Wood
2018-08-09  3:28             ` Bharat Bhushan
2018-08-09  6:11               ` Scott Wood
2018-08-09  7:04                 ` Bharat Bhushan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180807180938.GA13623@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=Bharat.Bhushan@nxp.com \
    --cc=benh@kernel.crashing.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@kernel.crashing.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=mpe@ellerman.id.au \
    --cc=oss@buserror.net \
    --cc=paulus@samba.org \
    --cc=tyreld@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).