From: Peter Zijlstra <peterz@infradead.org>
To: Christophe LEROY <christophe.leroy@c-s.fr>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH] perf: enum overflow in uapi/linux/perf_event.h
Date: Fri, 7 Sep 2018 16:23:53 +0200 [thread overview]
Message-ID: <20180907142353.GI24106@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <7a086a56-a896-9513-7315-9d0d21b61a44@c-s.fr>
On Fri, Sep 07, 2018 at 04:15:33PM +0200, Christophe LEROY wrote:
> Ah yes, it seems that GCC is happy. So sparse should be fixed instead ?
Ideally, yes.
> Anyway, is it really correct to put this constant inside that enum, after
> PERF_SAMPLE_MAX ?
It is a bit of a hack, agreed. What we do is use the top bit of that
word (u64) for some internal state. By placing it there (after MAX) we
ensure it is not available for userspace (trying to set it will return
in -EINVAL) and by keeping it in the enum we know that bit is
unavailable for future use.
I have a patch queued that puts a little comment on that:
https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=perf/urgent&id=34cad593c9ea350a1811ab718e64b36e5cde870c
(url is not stable, as I regenerate that git tree from quilt every so
often, but it should probably last the day).
next prev parent reply other threads:[~2018-09-07 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 13:27 [PATCH] perf: enum overflow in uapi/linux/perf_event.h Christophe Leroy
2018-09-07 13:42 ` Peter Zijlstra
2018-09-07 13:50 ` Christophe Leroy
2018-09-07 13:58 ` Peter Zijlstra
2018-09-07 14:13 ` Peter Zijlstra
2018-09-07 14:15 ` Christophe LEROY
2018-09-07 14:23 ` Peter Zijlstra [this message]
2018-09-07 18:43 ` Luc Van Oostenryck
2018-09-07 23:55 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907142353.GI24106@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=christophe.leroy@c-s.fr \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).