From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 11/12] powerpc: Check prom_init for disallowed sections
Date: Mon, 15 Oct 2018 13:49:59 +1100 [thread overview]
Message-ID: <20181015025000.4522-11-benh@kernel.crashing.org> (raw)
In-Reply-To: <20181015025000.4522-1-benh@kernel.crashing.org>
prom_init.c must not modify the kernel image outside
of the .bss.prominit section. Thus make sure that
prom_init.o doesn't have anything in any of these:
.data
.bss
.init.data
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
arch/powerpc/kernel/prom_init_check.sh | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
index acb6b9226352..667df97d2595 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh
@@ -28,6 +28,18 @@ OBJ="$2"
ERROR=0
+function check_section()
+{
+ file=$1
+ section=$2
+ size=$(objdump -h -j $section $file 2>/dev/null | awk "\$2 == \"$section\" {print \$3}")
+ size=${size:-0}
+ if [ $size -ne 0 ]; then
+ ERROR=1
+ echo "Error: Section $section not empty in prom_init.c" >&2
+ fi
+}
+
for UNDEF in $($NM -u $OBJ | awk '{print $2}')
do
# On 64-bit nm gives us the function descriptors, which have
@@ -66,4 +78,8 @@ do
fi
done
+check_section $OBJ .data
+check_section $OBJ .bss
+check_section $OBJ .init.data
+
exit $ERROR
--
2.17.1
next prev parent reply other threads:[~2018-10-15 2:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 2:49 [PATCH 01/12] powerpc/prom_init: Make of_workarounds static Benjamin Herrenschmidt
2018-10-15 2:49 ` [PATCH 02/12] powerpc/prom_init: Make "fake_elf" const Benjamin Herrenschmidt
2018-10-15 2:49 ` [PATCH 03/12] powerpc/prom_init: Make "default_colors" const Benjamin Herrenschmidt
2018-10-15 2:49 ` [PATCH 04/12] powerpc/prom_init: Replace __initdata with __prombss when applicable Benjamin Herrenschmidt
2018-10-19 2:51 ` [04/12] " Michael Ellerman
2018-10-15 2:49 ` [PATCH 05/12] powerpc/prom_init: Remove support for OPAL v2 Benjamin Herrenschmidt
2018-10-19 2:51 ` [05/12] " Michael Ellerman
2018-10-15 2:49 ` [PATCH 06/12] powerpc/prom_init: Move prom_radix_disable to __prombss Benjamin Herrenschmidt
2018-10-19 2:51 ` [06/12] " Michael Ellerman
2018-10-15 2:49 ` [PATCH 07/12] powerpc/prom_init: Move ibm_arch_vec " Benjamin Herrenschmidt
2018-10-19 2:51 ` [07/12] " Michael Ellerman
2018-10-15 2:49 ` [PATCH 08/12] powerpc/prom_init: Move const structures to __initconst Benjamin Herrenschmidt
2018-10-19 2:51 ` [08/12] " Michael Ellerman
2018-10-15 2:49 ` [PATCH 09/12] powerpc/prom_init: Move a few remaining statics to appropriate sections Benjamin Herrenschmidt
2018-10-19 2:51 ` [09/12] " Michael Ellerman
2018-10-15 2:49 ` [PATCH 10/12] powerpc/prom_init: Move __prombss to it's own section and store it in .bss Benjamin Herrenschmidt
2018-10-19 2:51 ` [10/12] " Michael Ellerman
2018-10-15 2:49 ` Benjamin Herrenschmidt [this message]
2018-10-19 2:51 ` [11/12] powerpc: Check prom_init for disallowed sections Michael Ellerman
2018-10-15 2:50 ` [PATCH 12/12] powerpc/prom_init: Generate "phandle" instead of "linux, phandle" Benjamin Herrenschmidt
2018-10-19 2:51 ` [12/12] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015025000.4522-11-benh@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).