Hi Russell, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on next-20181016] [cannot apply to v4.19-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Russell-Currey/powerpc-64s-Kernel-Hypervisor-Restricted-Access-Prevention/20181017-153543 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-storcenter_defconfig (attached as .config) compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=powerpc All errors (new ones prefixed by >>): In file included from include/linux/uaccess.h:14:0, from net/core/datagram.c:40: arch/powerpc/include/asm/uaccess.h: In function 'unlock_user_access': >> arch/powerpc/include/asm/uaccess.h:69:6: error: implicit declaration of function 'mmu_has_feature'; did you mean 'firmware_has_feature'? [-Werror=implicit-function-declaration] if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~ firmware_has_feature >> arch/powerpc/include/asm/uaccess.h:69:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'? if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~~~~~ CPU_FTR_CAN_NAP arch/powerpc/include/asm/uaccess.h:69:22: note: each undeclared identifier is reported only once for each function it appears in arch/powerpc/include/asm/uaccess.h: In function 'lock_user_access': arch/powerpc/include/asm/uaccess.h:83:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'? if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~~~~~ CPU_FTR_CAN_NAP In file included from include/linux/mm_types.h:18:0, from include/linux/mm.h:17, from net/core/datagram.c:41: arch/powerpc/include/asm/mmu.h: At top level: >> arch/powerpc/include/asm/mmu.h:209:20: error: conflicting types for 'mmu_has_feature' static inline bool mmu_has_feature(unsigned long feature) ^~~~~~~~~~~~~~~ In file included from include/linux/uaccess.h:14:0, from net/core/datagram.c:40: arch/powerpc/include/asm/uaccess.h:69:6: note: previous implicit declaration of 'mmu_has_feature' was here if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/uaccess.h:14:0, from include/linux/crypto.h:26, from include/crypto/skcipher.h:16, from include/crypto/chacha20.h:9, from lib/chacha20.c:17: arch/powerpc/include/asm/uaccess.h: In function 'unlock_user_access': >> arch/powerpc/include/asm/uaccess.h:69:6: error: implicit declaration of function 'mmu_has_feature'; did you mean 'firmware_has_feature'? [-Werror=implicit-function-declaration] if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~ firmware_has_feature >> arch/powerpc/include/asm/uaccess.h:69:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'? if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~~~~~ CPU_FTR_CAN_NAP arch/powerpc/include/asm/uaccess.h:69:22: note: each undeclared identifier is reported only once for each function it appears in arch/powerpc/include/asm/uaccess.h: In function 'lock_user_access': arch/powerpc/include/asm/uaccess.h:83:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'? if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~~~~~ CPU_FTR_CAN_NAP cc1: some warnings being treated as errors -- In file included from include/linux/uaccess.h:14:0, from arch/powerpc/kernel/module.c:25: arch/powerpc/include/asm/uaccess.h: In function 'unlock_user_access': >> arch/powerpc/include/asm/uaccess.h:69:6: error: implicit declaration of function 'mmu_has_feature'; did you mean 'firmware_has_feature'? [-Werror=implicit-function-declaration] if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~ firmware_has_feature >> arch/powerpc/include/asm/uaccess.h:69:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'? if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~~~~~ CPU_FTR_CAN_NAP arch/powerpc/include/asm/uaccess.h:69:22: note: each undeclared identifier is reported only once for each function it appears in arch/powerpc/include/asm/uaccess.h: In function 'lock_user_access': arch/powerpc/include/asm/uaccess.h:83:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'? if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { ^~~~~~~~~~~~~~~~~~~ CPU_FTR_CAN_NAP cc1: all warnings being treated as errors vim +69 arch/powerpc/include/asm/uaccess.h 64 65 static inline unsigned long unlock_user_access(void) 66 { 67 unsigned long amr; 68 > 69 if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) { 70 amr = mfspr(SPRN_AMR); 71 72 isync(); 73 mtspr(SPRN_AMR, 0); 74 isync(); 75 return amr; 76 } 77 78 return 0; 79 } 80 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation