* [PATCH] powerpc: Add missing include <asm/stacktrace.h>
@ 2018-10-17 19:25 Mathieu Malaterre
2018-10-18 4:37 ` Christophe LEROY
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Malaterre @ 2018-10-17 19:25 UTC (permalink / raw)
To: Michael Ellerman
Cc: Mathieu Malaterre, Paul Mackerras, linuxppc-dev, linux-kernel
In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the
function show_user_instructions was added.
This commit adds an include of header file <asm/stacktrace.h> to provide
the missing function prototype. Silence the following gcc warning
(treated as error with W=1):
arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
arch/powerpc/kernel/process.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index bb6ac471a784..1c64491e9702 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -65,6 +65,7 @@
#include <asm/livepatch.h>
#include <asm/cpu_has_feature.h>
#include <asm/asm-prototypes.h>
+#include <asm/stacktrace.h>
#include <linux/kprobes.h>
#include <linux/kdebug.h>
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Add missing include <asm/stacktrace.h>
2018-10-17 19:25 [PATCH] powerpc: Add missing include <asm/stacktrace.h> Mathieu Malaterre
@ 2018-10-18 4:37 ` Christophe LEROY
2018-10-18 6:34 ` Mathieu Malaterre
0 siblings, 1 reply; 3+ messages in thread
From: Christophe LEROY @ 2018-10-18 4:37 UTC (permalink / raw)
To: Mathieu Malaterre, Michael Ellerman
Cc: linuxppc-dev, Paul Mackerras, linux-kernel
Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit :
> In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the
> function show_user_instructions was added.
>
> This commit adds an include of header file <asm/stacktrace.h> to provide
> the missing function prototype. Silence the following gcc warning
> (treated as error with W=1):
>
> arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
This is already fixed, see
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c9386bfd37d37f29588de9ea9add455510049c33
Christophe
> ---
> arch/powerpc/kernel/process.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index bb6ac471a784..1c64491e9702 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -65,6 +65,7 @@
> #include <asm/livepatch.h>
> #include <asm/cpu_has_feature.h>
> #include <asm/asm-prototypes.h>
> +#include <asm/stacktrace.h>
>
> #include <linux/kprobes.h>
> #include <linux/kdebug.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Add missing include <asm/stacktrace.h>
2018-10-18 4:37 ` Christophe LEROY
@ 2018-10-18 6:34 ` Mathieu Malaterre
0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2018-10-18 6:34 UTC (permalink / raw)
To: Christophe LEROY; +Cc: Paul Mackerras, linuxppc-dev, LKML
On Thu, Oct 18, 2018 at 6:37 AM Christophe LEROY
<christophe.leroy@c-s.fr> wrote:
>
>
>
> Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit :
> > In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the
> > function show_user_instructions was added.
> >
> > This commit adds an include of header file <asm/stacktrace.h> to provide
> > the missing function prototype. Silence the following gcc warning
> > (treated as error with W=1):
> >
> > arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]
> >
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
>
> This is already fixed, see
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c9386bfd37d37f29588de9ea9add455510049c33
Excellent !
Sorry for the noise :(
> Christophe
>
> > ---
> > arch/powerpc/kernel/process.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> > index bb6ac471a784..1c64491e9702 100644
> > --- a/arch/powerpc/kernel/process.c
> > +++ b/arch/powerpc/kernel/process.c
> > @@ -65,6 +65,7 @@
> > #include <asm/livepatch.h>
> > #include <asm/cpu_has_feature.h>
> > #include <asm/asm-prototypes.h>
> > +#include <asm/stacktrace.h>
> >
> > #include <linux/kprobes.h>
> > #include <linux/kdebug.h>
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-18 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-17 19:25 [PATCH] powerpc: Add missing include <asm/stacktrace.h> Mathieu Malaterre
2018-10-18 4:37 ` Christophe LEROY
2018-10-18 6:34 ` Mathieu Malaterre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).