From: Scott Wood <oss@buserror.net>
To: Li Yang <leoyang.li@nxp.com>, Zhang Wei <zw@zh-kernel.org>
Cc: dmaengine@vger.kernel.org, Peng Ma <peng.ma@nxp.com>,
Wen He <wen.he_1@nxp.com>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH] dmaengine: fsldma: Add 64-bit I/O accessors for powerpc64
Date: Fri, 21 Dec 2018 22:34:45 -0600 [thread overview]
Message-ID: <20181222043445.GA29462@home.buserror.net> (raw)
Otherwise 64-bit PPC builds fail with undefined references
to these accessors.
Cc: Peng Ma <peng.ma@nxp.com>
Cc: Wen He <wen.he_1@nxp.com>
Fixes: 68997fff94afa (" dmaengine: fsldma: Adding macro FSL_DMA_IN/OUT implement for ARM platform")
Signed-off-by: Scott Wood <oss@buserror.net>
---
Is there any reason why ioreadXXbe() etc can't be used on PPC as well?
drivers/dma/fsldma.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/fsldma.h b/drivers/dma/fsldma.h
index 88db939c04a1..a9b12f82b5c3 100644
--- a/drivers/dma/fsldma.h
+++ b/drivers/dma/fsldma.h
@@ -202,7 +202,12 @@ struct fsldma_chan {
#define fsl_iowrite32(v, p) out_le32(p, v)
#define fsl_iowrite32be(v, p) out_be32(p, v)
-#ifndef __powerpc64__
+#ifdef __powerpc64__
+#define fsl_ioread64(p) in_le64(p)
+#define fsl_ioread64be(p) in_be64(p)
+#define fsl_iowrite64(v, p) out_le64(p, v)
+#define fsl_iowrite64be(v, p) out_be64(p, v)
+#else
static u64 fsl_ioread64(const u64 __iomem *addr)
{
u32 fsl_addr = lower_32_bits(addr);
--
2.17.1
next reply other threads:[~2018-12-22 4:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 4:34 Scott Wood [this message]
2018-12-24 3:42 ` [PATCH] dmaengine: fsldma: Add 64-bit I/O accessors for powerpc64 Peng Ma
2018-12-24 4:45 ` Scott Wood
2018-12-24 5:29 ` Peng Ma
2019-01-19 12:58 ` Vinod Koul
2019-01-25 5:54 ` Peng Ma
2019-02-04 7:27 ` Vinod Koul
2019-02-11 2:33 ` Peng Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222043445.GA29462@home.buserror.net \
--to=oss@buserror.net \
--cc=dmaengine@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peng.ma@nxp.com \
--cc=wen.he_1@nxp.com \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).