From: LEROY Christophe <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, chunkeey@gmail.com
Subject: Re: [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings
Date: Tue, 01 Jan 2019 17:52:19 +0100 [thread overview]
Message-ID: <20190101175219.Horde.M9y96Jn9ywiZ5BbROIsFAg1@messagerie.si.c-s.fr> (raw)
In-Reply-To: <20190101035601.13200-1-mpe@ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> a écrit :
> Currently the code produces several warnings, eg:
>
> arch/powerpc/platforms/4xx/ocm.c:240:38: error: format '%llx'
> expects argument of type 'long long unsigned int', but argument 3
> has type 'phys_addr_t {aka unsigned int}'
> seq_printf(m, "PhysAddr : 0x%llx\n", ocm->phys);
> ~~~^ ~~~~~~~~~
>
> Fix it by using the special %pa[p] format for printing phys_addr_t.
> Note we need to pass the value by reference for the special specifier
> to work.
When I fixed the same problem in prom.c, you suggested to simply cast
it to unsigned long long. Is this a better solution ?
Christophe
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> arch/powerpc/platforms/4xx/ocm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/4xx/ocm.c
> b/arch/powerpc/platforms/4xx/ocm.c
> index c22b099c42f1..a1aaa1569d7c 100644
> --- a/arch/powerpc/platforms/4xx/ocm.c
> +++ b/arch/powerpc/platforms/4xx/ocm.c
> @@ -237,12 +237,12 @@ static int ocm_debugfs_show(struct seq_file
> *m, void *v)
> continue;
>
> seq_printf(m, "PPC4XX OCM : %d\n", ocm->index);
> - seq_printf(m, "PhysAddr : 0x%llx\n", ocm->phys);
> + seq_printf(m, "PhysAddr : %pa[p]\n", &(ocm->phys));
> seq_printf(m, "MemTotal : %d Bytes\n", ocm->memtotal);
> seq_printf(m, "MemTotal(NC) : %d Bytes\n", ocm->nc.memtotal);
> seq_printf(m, "MemTotal(C) : %d Bytes\n\n", ocm->c.memtotal);
>
> - seq_printf(m, "NC.PhysAddr : 0x%llx\n", ocm->nc.phys);
> + seq_printf(m, "NC.PhysAddr : %pa[p]\n", &(ocm->nc.phys));
> seq_printf(m, "NC.VirtAddr : 0x%p\n", ocm->nc.virt);
> seq_printf(m, "NC.MemTotal : %d Bytes\n", ocm->nc.memtotal);
> seq_printf(m, "NC.MemFree : %d Bytes\n", ocm->nc.memfree);
> @@ -252,7 +252,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v)
> blk->size, blk->owner);
> }
>
> - seq_printf(m, "\nC.PhysAddr : 0x%llx\n", ocm->c.phys);
> + seq_printf(m, "\nC.PhysAddr : %pa[p]\n", &(ocm->c.phys));
> seq_printf(m, "C.VirtAddr : 0x%p\n", ocm->c.virt);
> seq_printf(m, "C.MemTotal : %d Bytes\n", ocm->c.memtotal);
> seq_printf(m, "C.MemFree : %d Bytes\n", ocm->c.memfree);
> --
> 2.17.2
next prev parent reply other threads:[~2019-01-01 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 3:56 [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings Michael Ellerman
2019-01-01 3:56 ` [PATCH 2/2] powerpc/configs: Add PPC4xx_OCM to ppc40x_defconfig Michael Ellerman
2019-01-01 16:52 ` LEROY Christophe [this message]
2019-01-02 11:12 ` [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings Michael Ellerman
2019-01-02 11:31 ` [1/2] " Michael Ellerman
2019-01-04 20:46 ` Christian Lamparter
2019-01-08 9:54 ` Michael Ellerman
2019-01-08 17:21 ` Christian Lamparter
2019-01-11 13:10 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190101175219.Horde.M9y96Jn9ywiZ5BbROIsFAg1@messagerie.si.c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=chunkeey@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).