linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: vmlinux.lds: Drop Binutils 2.18 workarounds
@ 2019-03-21  0:32 Joel Stanley
  2019-03-21 23:34 ` Segher Boessenkool
  2019-03-26  0:55 ` Michael Ellerman
  0 siblings, 2 replies; 18+ messages in thread
From: Joel Stanley @ 2019-03-21  0:32 UTC (permalink / raw)
  To: linuxppc-dev

Segher added some workarounds for GCC 4.2 and bintuils 2.18. We now set
4.6 and 2.20 as the minimum, so they can be dropped.

This is mostly a revert of c69cccc95fe4 ("powerpc: Fix build bug with
binutils < 2.18 and GCC < 4.2").

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/powerpc/kernel/vmlinux.lds.S | 35 ++++---------------------------
 1 file changed, 4 insertions(+), 31 deletions(-)

diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
index 060a1acd7c6d..0551e9846676 100644
--- a/arch/powerpc/kernel/vmlinux.lds.S
+++ b/arch/powerpc/kernel/vmlinux.lds.S
@@ -17,25 +17,6 @@
 
 ENTRY(_stext)
 
-PHDRS {
-	kernel PT_LOAD FLAGS(7); /* RWX */
-	notes PT_NOTE FLAGS(0);
-	dummy PT_NOTE FLAGS(0);
-
-	/* binutils < 2.18 has a bug that makes it misbehave when taking an
-	   ELF file with all segments at load address 0 as input.  This
-	   happens when running "strip" on vmlinux, because of the AT() magic
-	   in this linker script.  People using GCC >= 4.2 won't run into
-	   this problem, because the "build-id" support will put some data
-	   into the "notes" segment (at a non-zero load address).
-
-	   To work around this, we force some data into both the "dummy"
-	   segment and the kernel segment, so the dummy segment will get a
-	   non-zero load address.  It's not enough to always create the
-	   "notes" segment, since if nothing gets assigned to it, its load
-	   address will be zero.  */
-}
-
 #ifdef CONFIG_PPC64
 OUTPUT_ARCH(powerpc:common64)
 jiffies = jiffies_64;
@@ -77,7 +58,7 @@ SECTIONS
 #else /* !CONFIG_PPC64 */
 		HEAD_TEXT
 #endif
-	} :kernel
+	}
 
 	__head_end = .;
 
@@ -126,7 +107,7 @@ SECTIONS
 		__got2_end = .;
 #endif /* CONFIG_PPC32 */
 
-	} :kernel
+	}
 
 	. = ALIGN(ETEXT_ALIGN_SIZE);
 	_etext = .;
@@ -177,15 +158,7 @@ SECTIONS
 #endif
 	EXCEPTION_TABLE(0)
 
-	NOTES :kernel :notes
-
-	/* The dummy segment contents for the bug workaround mentioned above
-	   near PHDRS.  */
-	.dummy : AT(ADDR(.dummy) - LOAD_OFFSET) {
-		LONG(0)
-		LONG(0)
-		LONG(0)
-	} :kernel :dummy
+	NOTES
 
 /*
  * Init sections discarded at runtime
@@ -200,7 +173,7 @@ SECTIONS
 #ifdef CONFIG_PPC64
 		*(.tramp.ftrace.init);
 #endif
-	} :kernel
+	}
 
 	/* .exit.text is discarded at runtime, not link time,
 	 * to deal with references from __bug_table
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 18+ messages in thread
end of thread, other threads:[~2019-03-28 15:14 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21  0:32 [PATCH] powerpc: vmlinux.lds: Drop Binutils 2.18 workarounds Joel Stanley
2019-03-21 23:34 ` Segher Boessenkool
2019-03-22  0:22   ` Michael Ellerman
2019-03-26  0:55 ` Michael Ellerman
2019-03-26  7:55   ` Christophe Leroy
2019-03-26 18:19     ` Segher Boessenkool
2019-03-26 19:28       ` Christophe Leroy
2019-03-26 20:12         ` Segher Boessenkool
2019-03-26 22:29           ` Segher Boessenkool
2019-03-26 22:59             ` Segher Boessenkool
2019-03-27  6:40             ` Christophe Leroy
2019-03-27 12:47               ` Segher Boessenkool
2019-03-27 18:21                 ` Segher Boessenkool
2019-03-28  6:19                   ` Christophe Leroy
2019-03-28 15:11                     ` Segher Boessenkool
2019-03-27  8:56           ` Christophe Leroy
2019-03-27  9:09             ` Christophe Leroy
2019-03-26  8:08   ` Christophe Leroy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).