From: Christoph Hellwig <hch@lst.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian Zigotzky <chzigotzky@xenosoft.de>,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook
Date: Mon, 10 Jun 2019 10:18:25 +0200 [thread overview]
Message-ID: <20190610081825.GA16534@lst.de> (raw)
In-Reply-To: <30000803-3772-3edf-f4a9-55122d504f3f@lwfinger.net>
On Sat, Jun 08, 2019 at 04:52:24PM -0500, Larry Finger wrote:
> On 6/7/19 12:29 PM, Christoph Hellwig wrote:
>> I don't think we should work around this in the driver, we need to fix
>> it in the core. I'm curious why my previous patch didn't work. Can
>> you throw in a few printks what failed? I.e. did dma_direct_supported
>> return false? Did the actual allocation fail?
>
> Routine dma_direct_supported() returns true.
>
> The failure is in routine dma_set_mask() in the following if test:
>
> if (!dev->dma_mask || !dma_supported(dev, mask))
> return -EIO;
>
> For b43legacy, dev->dma_mask is 0xc265684800000000.
> dma_supported(dev, mask) is 0xc08b000000000000, mask is 0x3fffffff, and
> the routine returns -EIO.
>
> For b43, dev->dma_mask is 0xc265684800000001,
> dma_supported(dev, mask) is 0xc08b000000000000, mask is 0x77777777, and
> the routine returns 0.
I don't fully understand what values the above map to. Can you send
me your actual debugging patch as well?
next prev parent reply other threads:[~2019-06-10 8:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 22:50 [BISECTED REGRESSION] b43legacy broken on G4 PowerBook Aaro Koskinen
2019-06-06 0:54 ` Benjamin Herrenschmidt
2019-06-06 9:31 ` Aaro Koskinen
2019-06-06 10:56 ` Benjamin Herrenschmidt
2019-06-06 10:57 ` Benjamin Herrenschmidt
2019-06-06 11:43 ` Christoph Hellwig
2019-06-06 19:26 ` Larry Finger
2019-06-06 20:11 ` Larry Finger
2019-06-06 3:06 ` Larry Finger
2019-06-06 6:40 ` Christoph Hellwig
2019-06-07 17:25 ` Larry Finger
2019-06-07 17:29 ` Christoph Hellwig
2019-06-07 18:50 ` Larry Finger
2019-06-08 21:52 ` Larry Finger
2019-06-10 8:18 ` Christoph Hellwig [this message]
2019-06-10 16:09 ` Larry Finger
2019-06-11 6:05 ` Christoph Hellwig
2019-06-11 22:20 ` Larry Finger
2019-06-11 22:46 ` Aaro Koskinen
2019-06-12 1:57 ` Larry Finger
2019-06-11 22:46 ` Benjamin Herrenschmidt
2019-06-12 1:52 ` Larry Finger
2019-06-12 3:32 ` Benjamin Herrenschmidt
2019-06-12 6:55 ` Christoph Hellwig
2019-06-12 19:41 ` Larry Finger
2019-06-12 21:59 ` Benjamin Herrenschmidt
2019-06-13 7:29 ` Christoph Hellwig
2019-06-11 17:48 ` Andreas Schwab
2019-06-08 4:21 ` Benjamin Herrenschmidt
2019-06-08 7:23 ` Christoph Hellwig
2019-06-10 18:44 ` Larry Finger
2019-06-11 5:56 ` Benjamin Herrenschmidt
2019-06-11 6:08 ` Christoph Hellwig
2019-06-11 6:58 ` Benjamin Herrenschmidt
2019-06-11 6:59 ` Benjamin Herrenschmidt
2019-06-11 7:54 ` Christoph Hellwig
2019-06-11 9:04 ` Benjamin Herrenschmidt
2019-06-11 7:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610081825.GA16534@lst.de \
--to=hch@lst.de \
--cc=Larry.Finger@lwfinger.net \
--cc=aaro.koskinen@iki.fi \
--cc=chzigotzky@xenosoft.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).