From: Christoph Hellwig <hch@infradead.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Sam Bobroff <sbobroff@linux.ibm.com>,
Alistair Popple <alistair@popple.id.au>,
Christoph Hellwig <hch@infradead.org>,
Oliver O'Halloran <oohall@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel v4 2/4] powerpc/iommu: Allow bypass-only for DMA
Date: Mon, 15 Jul 2019 05:35:48 -0700 [thread overview]
Message-ID: <20190715123548.GA29453@infradead.org> (raw)
In-Reply-To: <1e9d2b30-015d-130e-4d83-c222f87afdc1@ozlabs.ru>
On Mon, Jul 15, 2019 at 06:33:00PM +1000, Alexey Kardashevskiy wrote:
>
>
> On 13/07/2019 01:20, Christoph Hellwig wrote:
> > > This skips the 32bit DMA setup check if the bypass is can be selected.
> >
> > That sentence does not parse. I think you need to dop the "can be"
> > based on the actual patch.
>
>
> "the 32bit DMA setup check" is
> "if (!(tbl = get_iommu_table_base(dev)))".
>
> I can rephrase though.
What I mean is to replace
"This skips the 32bit DMA setup check if the bypass is can be selected."
with
"This skips the 32bit DMA setup check if the bypass is selected."
or alternatively:
"This skips the 32bit DMA setup check if the bypass can be selected."
but I think the first version is more accurate.
next prev parent reply other threads:[~2019-07-15 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 9:45 [PATCH kernel v4 0/4 repost] powerpc/ioda2: Yet another attempt to allow DMA masks between 32 and 59 Alexey Kardashevskiy
2019-07-12 9:45 ` [PATCH kernel v4 1/4] powerpc/powernv/ioda: Fix race in TCE level allocation Alexey Kardashevskiy
2019-07-12 9:45 ` [PATCH kernel v4 2/4] powerpc/iommu: Allow bypass-only for DMA Alexey Kardashevskiy
2019-07-12 15:20 ` Christoph Hellwig
2019-07-15 8:33 ` Alexey Kardashevskiy
2019-07-15 12:35 ` Christoph Hellwig [this message]
2019-07-12 9:45 ` [PATCH kernel v4 3/4] powerpc/powernv/ioda2: Allocate TCE table levels on demand for default DMA window Alexey Kardashevskiy
2019-07-12 9:45 ` [PATCH kernel v4 4/4] powerpc/powernv/ioda2: Create bigger default window with 64k IOMMU pages Alexey Kardashevskiy
2019-07-12 15:25 ` Christoph Hellwig
2019-07-12 15:28 ` [PATCH kernel v4 0/4 repost] powerpc/ioda2: Yet another attempt to allow DMA masks between 32 and 59 Christoph Hellwig
2019-07-15 8:43 ` Alexey Kardashevskiy
2019-07-15 12:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715123548.GA29453@infradead.org \
--to=hch@infradead.org \
--cc=aik@ozlabs.ru \
--cc=alistair@popple.id.au \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=sbobroff@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).