From: kbuild test robot <lkp@intel.com>
To: Sam Bobroff <sbobroff@linux.ibm.com>
Cc: aik@ozlabs.ru, oohall@gmail.com, linuxppc-dev@lists.ozlabs.org,
kbuild-all@01.org, tyreld@linux.vnet.ibm.com
Subject: Re: [PATCH v3 9/9] powerpc/eeh: Convert log messages to eeh_edev_* macros
Date: Wed, 24 Jul 2019 17:23:44 +0800 [thread overview]
Message-ID: <201907241746.mKIx06OX%lkp@intel.com> (raw)
In-Reply-To: <d5bbb2e9a39da905d656524bdf9e1b6705fd526a.1563853440.git.sbobroff@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3776 bytes --]
Hi Sam,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.3-rc1 next-20190724]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Sam-Bobroff/powerpc-64-Adjust-order-in-pcibios_init/20190724-134001
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/kernel/eeh_driver.c: In function 'eeh_add_virt_device':
>> arch/powerpc/kernel/eeh_driver.c:459:17: error: unused variable 'pdn' [-Werror=unused-variable]
struct pci_dn *pdn = eeh_dev_to_pdn(edev);
^~~
cc1: all warnings being treated as errors
vim +/pdn +459 arch/powerpc/kernel/eeh_driver.c
77bd7415 arch/powerpc/platforms/pseries/eeh_driver.c Linas Vepstas 2005-11-03 454
bf773df9 arch/powerpc/kernel/eeh_driver.c Sam Bobroff 2018-09-12 455 static void *eeh_add_virt_device(struct eeh_dev *edev)
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 456 {
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 457 struct pci_driver *driver;
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 458 struct pci_dev *dev = eeh_dev_to_pci_dev(edev);
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 @459 struct pci_dn *pdn = eeh_dev_to_pdn(edev);
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 460
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 461 if (!(edev->physfn)) {
6dad7bbd arch/powerpc/kernel/eeh_driver.c Sam Bobroff 2019-07-23 462 eeh_edev_warn(edev, "Not for VF\n");
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 463 return NULL;
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 464 }
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 465
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 466 driver = eeh_pcid_get(dev);
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 467 if (driver) {
46d4be41 arch/powerpc/kernel/eeh_driver.c Sam Bobroff 2018-05-25 468 if (driver->err_handler) {
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 469 eeh_pcid_put(dev);
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 470 return NULL;
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 471 }
46d4be41 arch/powerpc/kernel/eeh_driver.c Sam Bobroff 2018-05-25 472 eeh_pcid_put(dev);
46d4be41 arch/powerpc/kernel/eeh_driver.c Sam Bobroff 2018-05-25 473 }
67086e32 arch/powerpc/kernel/eeh_driver.c Wei Yang 2016-03-04 474
:::::: The code at line 459 was first introduced by commit
:::::: 67086e32b56481531ab1292b284e074b1a8d764c powerpc/eeh: powerpc/eeh: Support error recovery for VF PE
:::::: TO: Wei Yang <weiyang@linux.vnet.ibm.com>
:::::: CC: Michael Ellerman <mpe@ellerman.id.au>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25333 bytes --]
next prev parent reply other threads:[~2019-07-24 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 3:44 [PATCH v3 0/9] Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 1/9] powerpc/64: Adjust order in pcibios_init() Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 2/9] powerpc/eeh: Clear stale EEH_DEV_NO_HANDLER flag Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 3/9] powerpc/eeh: Improve debug messages around device addition Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 4/9] powerpc/eeh: Initialize EEH address cache earlier Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 5/9] powerpc/eeh: EEH for pSeries hot plug Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 6/9] powerpc/eeh: Refactor around eeh_probe_devices() Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 7/9] powerpc/eeh: Add bdfn field to eeh_dev Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 8/9] powerpc/eeh: Introduce EEH edev logging macros Sam Bobroff
2019-07-23 3:44 ` [PATCH v3 9/9] powerpc/eeh: Convert log messages to eeh_edev_* macros Sam Bobroff
2019-07-24 9:23 ` kbuild test robot [this message]
2019-07-24 9:47 ` Oliver O'Halloran
2019-07-25 3:33 ` Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907241746.mKIx06OX%lkp@intel.com \
--to=lkp@intel.com \
--cc=aik@ozlabs.ru \
--cc=kbuild-all@01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=sbobroff@linux.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).