LinuxPPC-Dev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dmaengine: fsldma: Mark expected switch fall-through
@ 2019-08-12  0:22 Gustavo A. R. Silva
  2019-08-12 19:40 ` Leo Li
  2019-08-13  4:38 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-12  0:22 UTC (permalink / raw)
  To: Li Yang, Zhang Wei, Vinod Koul, Dan Williams
  Cc: dmaengine, linuxppc-dev, linux-kernel, Gustavo A. R. Silva

Mark switch cases where we are expecting to fall through.

Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc):

drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’:
drivers/dma/fsldma.c:1165:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
   chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
   ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/dma/fsldma.c:1166:2: note: here
  case FSL_DMA_IP_83XX:
  ^~~~

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/dma/fsldma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 23e0a356f167..ad72b3f42ffa 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -1163,6 +1163,7 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev,
 	switch (chan->feature & FSL_DMA_IP_MASK) {
 	case FSL_DMA_IP_85XX:
 		chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
+		/* Fall through */
 	case FSL_DMA_IP_83XX:
 		chan->toggle_ext_start = fsl_chan_toggle_ext_start;
 		chan->set_src_loop_size = fsl_chan_set_src_loop_size;
-- 
2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] dmaengine: fsldma: Mark expected switch fall-through
  2019-08-12  0:22 [PATCH] dmaengine: fsldma: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-08-12 19:40 ` Leo Li
  2019-08-13  4:38 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Leo Li @ 2019-08-12 19:40 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Zhang Wei, Vinod Koul, Dan Williams
  Cc: dmaengine, linuxppc-dev, linux-kernel



> -----Original Message-----
> From: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Sent: Sunday, August 11, 2019 7:22 PM
> To: Leo Li <leoyang.li@nxp.com>; Zhang Wei <zw@zh-kernel.org>; Vinod
> Koul <vkoul@kernel.org>; Dan Williams <dan.j.williams@intel.com>
> Cc: linuxppc-dev@lists.ozlabs.org; dmaengine@vger.kernel.org; linux-
> kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Subject: [PATCH] dmaengine: fsldma: Mark expected switch fall-through
> 
> Mark switch cases where we are expecting to fall through.
> 
> Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc):
> 
> drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’:
> drivers/dma/fsldma.c:1165:26: warning: this statement may fall through [-
> Wimplicit-fallthrough=]
>    chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
>    ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/dma/fsldma.c:1166:2: note: here
>   case FSL_DMA_IP_83XX:
>   ^~~~
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Acked-by: Li Yang <leoyang.li@nxp.com>

> ---
>  drivers/dma/fsldma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index
> 23e0a356f167..ad72b3f42ffa 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1163,6 +1163,7 @@ static int fsl_dma_chan_probe(struct
> fsldma_device *fdev,
>  	switch (chan->feature & FSL_DMA_IP_MASK) {
>  	case FSL_DMA_IP_85XX:
>  		chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
> +		/* Fall through */
>  	case FSL_DMA_IP_83XX:
>  		chan->toggle_ext_start = fsl_chan_toggle_ext_start;
>  		chan->set_src_loop_size = fsl_chan_set_src_loop_size;
> --
> 2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmaengine: fsldma: Mark expected switch fall-through
  2019-08-12  0:22 [PATCH] dmaengine: fsldma: Mark expected switch fall-through Gustavo A. R. Silva
  2019-08-12 19:40 ` Leo Li
@ 2019-08-13  4:38 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-08-13  4:38 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: linux-kernel, Li Yang, Zhang Wei, dmaengine, Dan Williams, linuxppc-dev

On 11-08-19, 19:22, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc):
> 
> drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’:
> drivers/dma/fsldma.c:1165:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
>    ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/dma/fsldma.c:1166:2: note: here
>   case FSL_DMA_IP_83XX:
>   ^~~~

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12  0:22 [PATCH] dmaengine: fsldma: Mark expected switch fall-through Gustavo A. R. Silva
2019-08-12 19:40 ` Leo Li
2019-08-13  4:38 ` Vinod Koul

LinuxPPC-Dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \
		linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org linuxppc-dev@archiver.kernel.org
	public-inbox-index linuxppc-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox