From: David Miller <davem@davemloft.net>
To: julietk@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can run
Date: Wed, 21 Aug 2019 21:06:21 -0700 (PDT) [thread overview]
Message-ID: <20190821.210621.1830113293142016068.davem@davemloft.net> (raw)
In-Reply-To: <20190820213120.19880-1-julietk@linux.vnet.ibm.com>
From: Juliet Kim <julietk@linux.vnet.ibm.com>
Date: Tue, 20 Aug 2019 17:31:19 -0400
> Commit a5681e20b541 ("net/ibmnvic: Fix deadlock problem in reset")
> made the change to hold the RTNL lock during a reset to avoid deadlock
> but linkwatch_event is fired during the reset and needs the RTNL lock.
> That keeps linkwatch_event process from proceeding until the reset
> is complete. The reset process cannot tolerate the linkwatch_event
> processing after reset completes, so release the RTNL lock during the
> process to allow a chance for linkwatch_event to run during reset.
> This does not guarantee that the linkwatch_event will be processed as
> soon as link state changes, but is an improvement over the current code
> where linkwatch_event processing is always delayed, which prevents
> transmissions on the device from being deactivated leading transmit
> watchdog timer to time-out.
>
> Release the RTNL lock before link state change and re-acquire after
> the link state change to allow linkwatch_event to grab the RTNL lock
> and run during the reset.
>
> Fixes: a5681e20b541 ("net/ibmnvic: Fix deadlock problem in reset")
> Signed-off-by: Juliet Kim <julietk@linux.vnet.ibm.com>
Conditional locking, especialy such extensive use of conditional
locking as is being done here, is strongly discouraged and is always
indicative of bad design.
Please try to rework this change such that the code paths that want
to lock things a certain way are %100 segregated functionally into
different code paths and functions.
Or feel free to find a cleaner way to fix this.
prev parent reply other threads:[~2019-08-22 4:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 21:31 [PATCH 1/2] net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can run Juliet Kim
2019-08-20 21:31 ` [PATCH 2/2] net/ibmvnic: prevent more than one thread from running in reset Juliet Kim
2019-08-22 4:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821.210621.1830113293142016068.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=julietk@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).