From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alastair D'Silva <alastair@au1.ibm.com>
Cc: alastair@d-silva.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH v2] powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB
Date: Tue, 27 Aug 2019 08:19:33 +0200 [thread overview]
Message-ID: <20190827061933.GA29250@kroah.com> (raw)
In-Reply-To: <20190821001929.4253-1-alastair@au1.ibm.com>
On Wed, Aug 21, 2019 at 10:19:27AM +1000, Alastair D'Silva wrote:
> From: Alastair D'Silva <alastair@d-silva.org>
>
> The upstream commit:
> 22e9c88d486a ("powerpc/64: reuse PPC32 static inline flush_dcache_range()")
> has a similar effect, but since it is a rewrite of the assembler to C, is
> too invasive for stable. This patch is a minimal fix to address the issue in
> assembler.
>
> This patch applies cleanly to v5.2, v4.19 & v4.14.
>
> When calling flush_(inval_)dcache_range with a size >4GB, we were masking
> off the upper 32 bits, so we would incorrectly flush a range smaller
> than intended.
>
> This patch replaces the 32 bit shifts with 64 bit ones, so that
> the full size is accounted for.
>
> Changelog:
> v2
> - Add related upstream commit
Now applied, thanks.
greg k-h
next prev parent reply other threads:[~2019-08-27 6:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 0:19 [PATCH v2] powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB Alastair D'Silva
2019-08-26 16:50 ` Greg Kroah-Hartman
2019-08-26 20:08 ` Christophe Leroy
2019-08-27 6:18 ` Greg Kroah-Hartman
2019-08-27 1:50 ` Michael Ellerman
2019-08-27 6:19 ` Patch "powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB" has been added to the 4.14-stable tree gregkh
2019-08-27 6:19 ` Greg Kroah-Hartman [this message]
2019-08-27 6:19 ` Patch "powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB" has been added to the 4.19-stable tree gregkh
2019-08-27 6:20 ` Patch "powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB" has been added to the 5.2-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827061933.GA29250@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alastair@au1.ibm.com \
--cc=alastair@d-silva.org \
--cc=allison@lohutok.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).