From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A23C43331 for ; Sat, 7 Sep 2019 15:39:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBCD22178F for ; Sat, 7 Sep 2019 15:39:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBCD22178F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46Qdrh1KlgzDqfL for ; Sun, 8 Sep 2019 01:39:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=davemloft.net (client-ip=2620:137:e000::1:9; helo=shards.monkeyblade.net; envelope-from=davem@davemloft.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=davemloft.net Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46Qdpj5rYPzDq5k for ; Sun, 8 Sep 2019 01:37:29 +1000 (AEST) Received: from localhost (unknown [88.214.184.0]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2D524152EFC42; Sat, 7 Sep 2019 08:37:15 -0700 (PDT) Date: Sat, 07 Sep 2019 17:37:14 +0200 (CEST) Message-Id: <20190907.173714.1400426487600521308.davem@davemloft.net> To: julietk@linux.vnet.ibm.com Subject: Re: [PATCH] net/ibmvnic: free reset work of removed device from queue From: David Miller In-Reply-To: <20190905213001.19818-1-julietk@linux.vnet.ibm.com> References: <20190905213001.19818-1-julietk@linux.vnet.ibm.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Sep 2019 08:37:16 -0700 (PDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Juliet Kim Date: Thu, 5 Sep 2019 17:30:01 -0400 > Commit 36f1031c51a2 ("ibmvnic: Do not process reset during or after > device removal") made the change to exit reset if the driver has been > removed, but does not free reset work items of the adapter from queue. > > Ensure all reset work items are freed when breaking out of the loop early. > > Fixes: 36f1031c51a2 ("ibmnvic: Do not process reset during or after > device removal”) Please do not break up Fixes: tags into mutliple lines, also please do not put an empty line between the Fixes: tag and other tags like the Signed-off-by: > Signed-off-by: Juliet Kim Applied, thanks.