linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Michael Ellerman <mpe@ellerman.id.au>,
	PowerPC <linuxppc-dev@lists.ozlabs.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>
Subject: linux-next: build failure after merge of the powerpc tree
Date: Mon, 30 Sep 2019 10:13:42 +1000	[thread overview]
Message-ID: <20190930101342.36c1afa0@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

Hi all,

After merging the powerpc tree, today's linux-next build (powerpc64
allnoconfig) failed like this:

arch/powerpc/mm/book3s64/pgtable.c: In function 'flush_partition':
arch/powerpc/mm/book3s64/pgtable.c:216:3: error: implicit declaration of function 'radix__flush_all_lpid_guest'; did you mean 'radix__flush_all_lpid'? [-Werror=implicit-function-declaration]
  216 |   radix__flush_all_lpid_guest(lpid);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   radix__flush_all_lpid

Caused by commit

  99161de3a283 ("powerpc/64s/radix: tidy up TLB flushing code")

radix__flush_all_lpid_guest() is only declared for CONFIG_PPC_RADIX_MMU
which is not set for this build.

I am not sure why this did not show up earlier (maybe a Kconfig
change?).

I added the following hack for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 30 Sep 2019 10:09:17 +1000
Subject: [PATCH] powerpc/64s/radix: fix for "tidy up TLB flushing code" and
 !CONFIG_PPC_RADIX_MMU

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/include/asm/book3s/64/tlbflush-radix.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h b/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h
index 4ce795d30377..ca8db193ae38 100644
--- a/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h
+++ b/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h
@@ -35,6 +35,10 @@ static inline void radix__flush_all_lpid(unsigned int lpid)
 {
 	WARN_ON(1);
 }
+static inline void radix__flush_all_lpid_guest(unsigned int lpid)
+{
+	WARN_ON(1);
+}
 #endif
 
 extern void radix__flush_hugetlb_tlb_range(struct vm_area_struct *vma,
-- 
2.23.0.rc1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2019-09-30  0:15 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30  0:13 Stephen Rothwell [this message]
2019-10-03 23:05 ` linux-next: build failure after merge of the powerpc tree Michael Ellerman
2019-10-11  8:22 ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2023-02-10  3:38 Stephen Rothwell
2023-02-12 23:22 ` Michael Ellerman
2021-04-19  9:14 Stephen Rothwell
2021-04-19  9:59 ` Xiongwei Song
2021-04-19 12:24   ` Michael Ellerman
2021-02-09 10:19 Stephen Rothwell
2021-02-10  8:20 ` Nicholas Piggin
2021-02-10 11:18   ` Stephen Rothwell
2020-04-22  5:41 Stephen Rothwell
2020-04-22  6:35 ` Haren Myneni
2020-04-25 23:52 ` Michael Ellerman
2019-09-02 11:40 Stephen Rothwell
2019-09-02 11:52 ` Christoph Hellwig
2019-02-22  7:14 Stephen Rothwell
2019-02-22  7:37 ` Christophe Leroy
2019-02-22 11:28   ` Michael Ellerman
2018-03-29  7:43 Stephen Rothwell
2018-01-19  5:53 Stephen Rothwell
2018-01-18 22:26 Stephen Rothwell
2017-11-02  6:49 Stephen Rothwell
2017-11-14 11:12 ` Michael Ellerman
2016-11-22  8:58 Stephen Rothwell
2016-11-22 10:21 ` Stephen Rothwell
2016-11-23  2:02   ` Nicholas Piggin
2016-07-22  6:31 Stephen Rothwell
2016-07-01  5:27 Stephen Rothwell
2016-07-01  8:59 ` Colin Ian King
2016-01-07  8:16 Stephen Rothwell
2016-01-07 10:30 ` Michael Ellerman
2016-01-13  5:46   ` Aneesh Kumar K.V
2016-01-13  7:44     ` Michael Ellerman
2016-01-12 12:32 ` Michael Ellerman
2015-08-21  8:25 Stephen Rothwell
2015-08-21  8:59 ` Vasant Hegde
2015-08-21 23:40   ` Michael Ellerman
2015-08-22  4:09     ` Vasant Hegde
2015-08-22 11:16       ` Michael Ellerman
2014-08-06  6:31 Stephen Rothwell
2013-07-02  0:54 Stephen Rothwell
2013-07-02  2:00 ` Benjamin Herrenschmidt
2012-11-28  3:03 Stephen Rothwell
2012-11-28  4:28 ` Benjamin Herrenschmidt
2011-07-01  1:39 Stephen Rothwell
2011-07-01  3:00 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190930101342.36c1afa0@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).