From: Bjorn Helgaas <helgaas@kernel.org>
To: Tyrel Datwyler <tyreld@linux.ibm.com>
Cc: nathanl@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-pci@vger.kernel.org
Subject: Re: [RFC PATCH 0/9] Fixes and Enablement of ibm,drc-info property
Date: Tue, 1 Oct 2019 15:02:29 -0500 [thread overview]
Message-ID: <20191001200229.GA64312@google.com> (raw)
In-Reply-To: <1569910334-5972-1-git-send-email-tyreld@linux.ibm.com>
On Tue, Oct 01, 2019 at 01:12:05AM -0500, Tyrel Datwyler wrote:
> There was an initial previous effort yo add support for the PAPR
> architected ibm,drc-info property. This property provides a more
> memory compact representation of a paritions Dynamic Reconfig
> Connectors (DRC). These can otherwise be thought of the currently
> partitioned, or available, but yet to be partitioned, system resources
> such as cpus, memory, and physical/logical IOA devices.
>
> The initial implementation proved buggy and was fully turned of by
> disabling the bit in the appropriate CAS support vector. We now have
> PowerVM firmware in the field that supports this new property, and
> further to suppport partitions with 24TB+ or possible memory this
> property is required to perform platform migration.
>
> This serious fixup the short comings of the previous implementation
> in the areas of general implementation, cpu hotplug, and IOA hotplug.
>
> Tyrel Datwyler (9):
> powerpc/pseries: add cpu DLPAR support for drc-info property
> powerpc/pseries: fix bad drc_index_start value parsing of drc-info
> entry
> powerpc/pseries: fix drc-info mappings of logical cpus to drc-index
> PCI: rpaphp: fix up pointer to first drc-info entry
> PCI: rpaphp: don't rely on firmware feature to imply drc-info support
> PCI: rpaphp: add drc-info support for hotplug slot registration
> PCI: rpaphp: annotate and correctly byte swap DRC properties
> PCI: rpaphp: correctly match ibm,my-drc-index to drc-name when using
> drc-info
> powerpc: Enable support for ibm,drc-info property
>
> arch/powerpc/kernel/prom_init.c | 2 +-
> arch/powerpc/platforms/pseries/hotplug-cpu.c | 117 ++++++++++++++++------
> arch/powerpc/platforms/pseries/of_helpers.c | 8 +-
> arch/powerpc/platforms/pseries/pseries_energy.c | 23 ++---
> drivers/pci/hotplug/rpaphp_core.c | 124 +++++++++++++++++-------
> 5 files changed, 191 insertions(+), 83 deletions(-)
Michael, I assume you'll take care of this. If I were applying, I
would capitalize the commit subjects and fix the typos in the commit
logs, e.g.,
s/the this/the/
s/the the/that the/
s/short coming/shortcoming/
s/seperate/separate/
s/bid endian/big endian/
s/were appropriate/where appropriate/
s/name form/name from/
etc. git am also complains about space before tab whitespace errors.
And it adds a few lines >80 chars.
next prev parent reply other threads:[~2019-10-01 20:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 6:12 [RFC PATCH 0/9] Fixes and Enablement of ibm,drc-info property Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 1/9] powerpc/pseries: add cpu DLPAR support for drc-info property Tyrel Datwyler
2019-10-10 18:56 ` Nathan Lynch
2019-10-30 23:35 ` Tyrel Datwyler
2019-10-31 17:14 ` Nathan Lynch
2019-10-01 6:12 ` [RFC PATCH 2/9] powerpc/pseries: fix bad drc_index_start value parsing of drc-info entry Tyrel Datwyler
2019-10-10 19:04 ` Nathan Lynch
2019-10-10 20:16 ` powerpc/405GP, cuImage and PCI support Carlo Pisani
2019-10-31 0:15 ` [RFC PATCH 2/9] powerpc/pseries: fix bad drc_index_start value parsing of drc-info entry Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 3/9] powerpc/pseries: fix drc-info mappings of logical cpus to drc-index Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 4/9] PCI: rpaphp: fix up pointer to first drc-info entry Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 5/9] PCI: rpaphp: don't rely on firmware feature to imply drc-info support Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 6/9] PCI: rpaphp: add drc-info support for hotplug slot registration Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 7/9] PCI: rpaphp: annotate and correctly byte swap DRC properties Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 8/9] PCI: rpaphp: correctly match ibm, my-drc-index to drc-name when using drc-info Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 9/9] powerpc: Enable support for ibm,drc-info property Tyrel Datwyler
2019-10-01 20:02 ` Bjorn Helgaas [this message]
2019-10-31 0:15 ` [RFC PATCH 0/9] Fixes and Enablement of " Tyrel Datwyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001200229.GA64312@google.com \
--to=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).