From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87B4BECE58C for ; Fri, 11 Oct 2019 16:13:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34E1C206CD for ; Fri, 11 Oct 2019 16:13:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="U5/N6JMi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34E1C206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46qY105dPyzDqV5 for ; Sat, 12 Oct 2019 03:13:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::644; helo=mail-pl1-x644.google.com; envelope-from=keescook@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="U5/N6JMi"; dkim-atps=neutral Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46qXyZ47dkzDqTb for ; Sat, 12 Oct 2019 03:11:49 +1100 (AEDT) Received: by mail-pl1-x644.google.com with SMTP id q15so4664823pll.11 for ; Fri, 11 Oct 2019 09:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=G6L52gHbcOVXjcPSYcPZfDCdfNGSvtith//1lglITt4=; b=U5/N6JMiUj9QDTd24aIgmkS/ZCmGBjpKwM7U8CzxrzMf1lqZSNfbZ7O4pwV0bhEzEg wudUUYrZzrgNiboJm0ChoceZ3O1LmYFYV3Bvx9uhV6vTeclkuNrnADNJMjD6VX65LBtL he7FMaEjTbOKTJQ5f79wUMqxbvVvSYa6+a7mg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G6L52gHbcOVXjcPSYcPZfDCdfNGSvtith//1lglITt4=; b=KBrWdsaPkDzgxeTP+Lc2ZReEpDv28nA9oaEm7KfWDa1krr5C0T9dl5d0+W4k3xqO25 CQ6u3aUt16WxpoSEdWJP321NFiZKHy4duGjXlpzhr+v+kpPZ9pnf2/7toJ2fUMl9lOeu 6JCRqay/3RFdFpncPGYEFcZ5jiRYRprgjv+pATmy7erSYb8eVIF+/dx7W8YKMnoA7TRn bnGUUBGS68WUlwSiWfss4JCQcBHKZI+bAEPU+lb7yjmtXkkTTCpcDccRajQBaEis0cNp sMpu1vmA5sbVRY4/6bd6zduXSPXrbJ+69nBxT1pL6hskwNJMkDNfJ+4Om41Lic/9wSHR CKUw== X-Gm-Message-State: APjAAAWEMCpBe5p/h6VEpd3bsMd4eRAcr3865gWSoywnNVHxGIEKpFKc FMpleHjLG0ilex4xS/DNGz/02g== X-Google-Smtp-Source: APXvYqybFKi8DEP43HWkgZPyfZo8SqqFMMtnLHZ2tVbdiQx6dZitTSLWHEWMqDIFXmSN2gN3R3/hRg== X-Received: by 2002:a17:902:bf45:: with SMTP id u5mr15982728pls.62.1570810305781; Fri, 11 Oct 2019 09:11:45 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f6sm9294369pfq.169.2019.10.11.09.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 09:11:44 -0700 (PDT) Date: Fri, 11 Oct 2019 09:11:43 -0700 From: Kees Cook To: Segher Boessenkool Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note" Message-ID: <201910110910.48270FC97@keescook> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191011082519.GI9749@gate.crashing.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michal Simek , Dave Hansen , linux-ia64@vger.kernel.org, Yoshinori Sato , Arnd Bergmann , linux-xtensa@linux-xtensa.org, Will Deacon , x86@kernel.org, Heiko Carstens , linux-kernel@vger.kernel.org, Borislav Petkov , linux-parisc@vger.kernel.org, Andy Lutomirski , linux-alpha@vger.kernel.org, Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Oct 11, 2019 at 03:25:19AM -0500, Segher Boessenkool wrote: > On Thu, Oct 10, 2019 at 05:05:41PM -0700, Kees Cook wrote: > > The Program Header identifiers are internal to the linker scripts. In > > preparation for moving the NOTES segment declaration into RO_DATA, > > standardize the identifier for the PT_NOTE entry to "note" as used by > > all other architectures that emit PT_NOTE. > > All other archs are wrong, and "notes" is a much better name. This > segment does not contain a single "note", but multiple "notes". True, but the naming appears to be based off the Program Header name of "PT_NOTE". Regardless, it is an entirely internal-to-the-linker-script identifier, so I am just consolidating on a common name with the least number of collateral changes. -- Kees Cook