From: Nicolin Chen <nicoleotsuka@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz,
broonie@kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 -next] ASoC: fsl_mqs: Move static keyword to the front of declarations
Date: Fri, 11 Oct 2019 12:01:06 -0700 [thread overview]
Message-ID: <20191011190105.GA18114@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20191011143538.15300-1-yuehaibing@huawei.com>
On Fri, Oct 11, 2019 at 10:35:38PM +0800, YueHaibing wrote:
> gcc warn about this:
>
> sound/soc/fsl/fsl_mqs.c:146:1: warning:
> static is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> v2: Fix patch title
> ---
> sound/soc/fsl/fsl_mqs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
> index f7fc44e..0c813a4 100644
> --- a/sound/soc/fsl/fsl_mqs.c
> +++ b/sound/soc/fsl/fsl_mqs.c
> @@ -143,7 +143,7 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream,
> MQS_EN_MASK, 0);
> }
>
> -const static struct snd_soc_component_driver soc_codec_fsl_mqs = {
> +static const struct snd_soc_component_driver soc_codec_fsl_mqs = {
> .idle_bias_on = 1,
> .non_legacy_dai_naming = 1,
> };
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2019-10-11 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 10:56 [PATCH -next] ASoC: fsl_mqs: fix old-style function declaration YueHaibing
2019-10-11 13:12 ` Andreas Schwab
2019-10-11 14:02 ` Yuehaibing
2019-10-11 14:35 ` [PATCH v2 -next] ASoC: fsl_mqs: Move static keyword to the front of declarations YueHaibing
2019-10-11 19:01 ` Nicolin Chen [this message]
2019-10-14 12:04 ` Applied "ASoC: fsl_mqs: Move static keyword to the front of declarations" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011190105.GA18114@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).