From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Rob Herring <robh+dt@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
mad skateman <madskateman@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
"R.T.Dickinson" <rtd2@xtra.co.nz>,
Christian Zigotzky <chzigotzky@xenosoft.de>,
"contact@a-eon.com" <contact@a-eon.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Christian Zigotzky <info@xenosoft.de>
Subject: Re: Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates
Date: Wed, 23 Oct 2019 15:12:57 +0100 [thread overview]
Message-ID: <20191023141257.GA25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAL_JsqJpFy-g3earNjZs7jANx4pyRd=CDvZN3emMdXL5YNkYHQ@mail.gmail.com>
On Wed, Oct 23, 2019 at 08:52:33AM -0500, Rob Herring wrote:
> On Wed, Oct 23, 2019 at 1:41 AM Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> >
> > On Wed, 2019-10-23 at 16:42 +1100, Michael Ellerman wrote:
> > >
> > > Right, it seems of_dma_is_coherent() has baked in the assumption that
> > > devices are non-coherent unless explicitly marked as coherent.
> > >
> > > Which is wrong on all or at least most existing powerpc systems
> > > according to Ben.
> >
> > This is probably broken on sparc(64) as well and whatever else uses
> > DT and is an intrinsicly coherent architecture (did we ever have
> > DT enabled x86s ? Wasn't OLPC such a beast ?).
>
> Only if those platforms use one of the 5 drivers that call this function:
>
> drivers/ata/ahci_qoriq.c: qoriq_priv->is_dmacoherent =
> of_dma_is_coherent(np);
> drivers/crypto/ccree/cc_driver.c: new_drvdata->coherent =
> of_dma_is_coherent(np);
> drivers/iommu/arm-smmu-v3.c: if (of_dma_is_coherent(dev->of_node))
> drivers/iommu/arm-smmu.c: if (of_dma_is_coherent(dev->of_node))
> drivers/mmc/host/sdhci-of-esdhc.c: if (of_dma_is_coherent(dev->of_node))
>
> Curious that a PPC specific driver (ahci_qoriq) calls it...
Maybe because it is not PPC specific:
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:
compatible = "fsl,lx2160a-ahci";
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:
compatible = "fsl,lx2160a-ahci";
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:
compatible = "fsl,lx2160a-ahci";
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:
compatible = "fsl,lx2160a-ahci";
drivers/ata/ahci_qoriq.c: { .compatible = "fsl,lx2160a-ahci", .data = (void *)AHCI_LX2160A},
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-10-23 14:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7b549219-a2e1-08c7-331b-9c3e4fdb8a8f@xenosoft.de>
[not found] ` <3aeae0d8-e9be-2585-cbbd-70263cb495f1@xenosoft.de>
[not found] ` <20191015125105.GU25745@shell.armlinux.org.uk>
[not found] ` <5611f3bc-68aa-78ec-182a-1cb414202314@xenosoft.de>
[not found] ` <20191015131750.GV25745@shell.armlinux.org.uk>
2019-10-23 5:42 ` Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates Michael Ellerman
2019-10-23 6:41 ` Benjamin Herrenschmidt
2019-10-23 13:52 ` Rob Herring
2019-10-23 14:12 ` Russell King - ARM Linux admin [this message]
2019-10-23 14:31 ` Russell King - ARM Linux admin
2019-10-25 22:28 ` Rob Herring
2019-10-26 6:39 ` Christoph Hellwig
2019-10-28 8:47 ` Benjamin Herrenschmidt
2019-10-28 8:45 ` Benjamin Herrenschmidt
2019-10-23 14:20 ` Christian Zigotzky
2019-11-04 14:44 ` Christian Zigotzky
2019-11-05 7:50 ` Bug 205201 - overflow of DMA mask and bus mask Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023141257.GA25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=chzigotzky@xenosoft.de \
--cc=contact@a-eon.com \
--cc=info@xenosoft.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madskateman@gmail.com \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=rtd2@xtra.co.nz \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).