From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82625CA9ECF for ; Fri, 1 Nov 2019 13:25:14 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF69B2067D for ; Fri, 1 Nov 2019 13:25:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="g0t9IWVb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF69B2067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 474NGb0dMpzF6n0 for ; Sat, 2 Nov 2019 00:25:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::141; helo=mail-lf1-x141.google.com; envelope-from=linux@rasmusvillemoes.dk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="g0t9IWVb"; dkim-atps=neutral Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 474MKK4QnQzF4p3 for ; Fri, 1 Nov 2019 23:42:29 +1100 (AEDT) Received: by mail-lf1-x141.google.com with SMTP id 19so1970801lft.13 for ; Fri, 01 Nov 2019 05:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=td9IeMtAnKP3TNZfmfJvazvskLsY9wm2/Illqt7TzBU=; b=g0t9IWVbZwlbGUfe42OCviDf0Xj5nVyevQuGZEnMgLfjpAKphqtdzJEhNTgeJq19Rs 0QW0lur2U4C7+Hqd9TQsEODQMXwvLaOL7OhWWq8OKpNrwLsasSUx0ZC0CwR+VUcfXMhS UHtbeWLwVKEc0aDg0l5XldrFFe/FaIduB+JGM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=td9IeMtAnKP3TNZfmfJvazvskLsY9wm2/Illqt7TzBU=; b=YTyz4uU/KSu0DkjQSI20T1q7sGvZ3Ttpbs0vtoSk54jRalIiZ5J5zEnL7AyGASM0Tm KBd7LqyY1xszNKStckMq5hll6jfNbqsVpXj6+jjMHMpIsv1OBlNqkugNmxPmIJ6fE2JJ GVaMknxP1FlsE9PVCpPiHYDiPsuFFmELVMUuhRdlej+AuJdqttBLzHSaRZlOUF4EJil9 VGaWj4Qe1E4PqrBh/0lleMuztcxKvuiIYSZP0pkPl1kpCHZapB2wEmQ8917YbGJLxZlL x/lpRdowl4mwVXB6C3UXMRvJB0ZqQ3KgdlXYkn5wFpygI0N+D2/kYXp0hvTHgDtSx8oz NVxg== X-Gm-Message-State: APjAAAWdL/oxYiC73NNc/5waOvI1KHmG/uacRfeT8GKpw7+Mc0MIYJDh vfEvQ8sBbHI+2MbyPypuePnozA== X-Google-Smtp-Source: APXvYqxY2laHtfFgtTJ6vvKR4Xn06GwjZhA2wuPw7Ipw9dAvLGzODcePDlA6j5DNpYqbyvnIVabf3g== X-Received: by 2002:ac2:5967:: with SMTP id h7mr6973677lfp.119.1572612146522; Fri, 01 Nov 2019 05:42:26 -0700 (PDT) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id o26sm2458540lfi.57.2019.11.01.05.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 05:42:26 -0700 (PDT) From: Rasmus Villemoes To: Qiang Zhao , Li Yang , Christophe Leroy Subject: [PATCH v3 09/36] soc: fsl: qe: drop assign-only high_active in qe_ic_init Date: Fri, 1 Nov 2019 13:41:43 +0100 Message-Id: <20191101124210.14510-10-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101124210.14510-1-linux@rasmusvillemoes.dk> References: <20191018125234.21825-1-linux@rasmusvillemoes.dk> <20191101124210.14510-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Wood , Rasmus Villemoes , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" high_active is only assigned to but never used. Remove it. Signed-off-by: Rasmus Villemoes --- drivers/soc/fsl/qe/qe_ic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c index 8c874372416b..4b03060d8079 100644 --- a/drivers/soc/fsl/qe/qe_ic.c +++ b/drivers/soc/fsl/qe/qe_ic.c @@ -320,7 +320,7 @@ void __init qe_ic_init(struct device_node *node, unsigned int flags, { struct qe_ic *qe_ic; struct resource res; - u32 temp = 0, ret, high_active = 0; + u32 temp = 0, ret; ret = of_address_to_resource(node, 0, &res); if (ret) @@ -366,10 +366,8 @@ void __init qe_ic_init(struct device_node *node, unsigned int flags, temp |= CICR_GRTB; /* choose destination signal for highest priority interrupt */ - if (flags & QE_IC_HIGH_SIGNAL) { + if (flags & QE_IC_HIGH_SIGNAL) temp |= (SIGNAL_HIGH << CICR_HPIT_SHIFT); - high_active = 1; - } qe_ic_write(qe_ic->regs, QEIC_CICR, temp); -- 2.23.0