linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] powerpc/kexec: move kexec files into a dedicated subdir.
Date: Tue, 19 Nov 2019 18:51:13 +0100	[thread overview]
Message-ID: <20191119185113.Horde.6OywM5Gmhq3LRZDTsd-7HA1@messagerie.si.c-s.fr> (raw)
In-Reply-To: <87pnhpctrn.fsf@mpe.ellerman.id.au>

Michael Ellerman <mpe@ellerman.id.au> a écrit :

> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>> arch/powerpc/kernel/ contains 8 files dedicated to kexec.
>>
>> Move them into a dedicated subdirectory.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>
>> ---
>> v2: moved crash.c as well as it's part of kexec suite.
>> v3: renamed files to remove 'kexec' keyword from names.
>> v4: removed a ifdef in kexec/Makefile
>> ---
>>  arch/powerpc/kernel/Makefile                       | 19 +---------------
>>  arch/powerpc/kernel/kexec/Makefile                 | 25  
>> ++++++++++++++++++++++
>>  arch/powerpc/kernel/{ => kexec}/crash.c            |  0
>>  .../kernel/{kexec_elf_64.c => kexec/elf_64.c}      |  0
>>  arch/powerpc/kernel/{ima_kexec.c => kexec/ima.c}   |  0
>>  .../kernel/{machine_kexec.c => kexec/machine.c}    |  0
>>  .../{machine_kexec_32.c => kexec/machine_32.c}     |  0
>>  .../{machine_kexec_64.c => kexec/machine_64.c}     |  0
>>  .../machine_file_64.c}                             |  0
>>  .../{kexec_relocate_32.S => kexec/relocate_32.S}   |  2 +-
>>  10 files changed, 27 insertions(+), 19 deletions(-)
>>  create mode 100644 arch/powerpc/kernel/kexec/Makefile
>>  rename arch/powerpc/kernel/{ => kexec}/crash.c (100%)
>>  rename arch/powerpc/kernel/{kexec_elf_64.c => kexec/elf_64.c} (100%)
>>  rename arch/powerpc/kernel/{ima_kexec.c => kexec/ima.c} (100%)
>>  rename arch/powerpc/kernel/{machine_kexec.c => kexec/machine.c} (100%)
>>  rename arch/powerpc/kernel/{machine_kexec_32.c =>  
>> kexec/machine_32.c} (100%)
>>  rename arch/powerpc/kernel/{machine_kexec_64.c =>  
>> kexec/machine_64.c} (100%)
>>  rename arch/powerpc/kernel/{machine_kexec_file_64.c =>  
>> kexec/machine_file_64.c} (100%)
>>  rename arch/powerpc/kernel/{kexec_relocate_32.S =>  
>> kexec/relocate_32.S} (99%)
>
> I'm inclined to move the directory out of kernel, ie. up a level with mm
> and so on.
>
> And I also don't think the "machine" naming is useful anymore. It comes
> from the naming of the arch functions, eg. machine_kexec(), which was
> named to be analogous to machine_restart().
>
> So how about:
>
>   arch/powerpc/{kernel/machine_kexec.c => kexec/core.c}
>   arch/powerpc/{kernel/machine_kexec_32.c => kexec/core_32.c}
>   arch/powerpc/{kernel/machine_kexec_64.c => kexec/core_64.c}
>   arch/powerpc/{kernel => kexec}/crash.c
>   arch/powerpc/{kernel/kexec_elf_64.c => kexec/elf_64.c}
>   arch/powerpc/{kernel/machine_kexec_file_64.c => kexec/file_load.c}
>   arch/powerpc/{kernel/ima_kexec.c => kexec/ima.c}
>   arch/powerpc/{kernel/kexec_relocate_32.S => kexec/relocate_32.S}
>
> And we end up with:
>
>   $ find arch/powerpc/kexec
>   arch/powerpc/kexec/
>   arch/powerpc/kexec/file_load.c
>   arch/powerpc/kexec/relocate_32.S
>   arch/powerpc/kexec/core_64.c
>   arch/powerpc/kexec/ima.c
>   arch/powerpc/kexec/core.c
>   arch/powerpc/kexec/core_32.c
>   arch/powerpc/kexec/Makefile
>   arch/powerpc/kexec/crash.c
>   arch/powerpc/kexec/elf_64.c

That looks good

Christophe




  reply	other threads:[~2019-11-19 17:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 12:13 [PATCH v4 1/2] powerpc/32: Split kexec low level code out of misc_32.S Christophe Leroy
2019-10-29 12:13 ` [PATCH v4 2/2] powerpc/kexec: move kexec files into a dedicated subdir Christophe Leroy
2019-11-18 11:23   ` Michael Ellerman
2019-11-19 17:51     ` Christophe Leroy [this message]
2019-11-25 10:47 ` [PATCH v4 1/2] powerpc/32: Split kexec low level code out of misc_32.S Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191119185113.Horde.6OywM5Gmhq3LRZDTsd-7HA1@messagerie.si.c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).