From: kbuild test robot <lkp@intel.com>
To: Sourabh Jain <sourabhjain@linux.ibm.com>
Cc: kbuild-all@lists.01.org, corbet@lwn.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Sourabh Jain <sourabhjain@linux.ibm.com>,
linuxppc-dev@ozlabs.org, mahesh@linux.vnet.ibm.com,
hbathini@linux.ibm.com
Subject: Re: [PATCH v3 2/4] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files
Date: Sat, 23 Nov 2019 19:21:15 +0800 [thread overview]
Message-ID: <201911231940.11VsnYpL%lkp@intel.com> (raw)
In-Reply-To: <20191109122339.20484-3-sourabhjain@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3069 bytes --]
Hi Sourabh,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.4-rc8 next-20191122]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sourabh-Jain/reorganize-and-add-FADump-sysfs-files/20191110-091753
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-rhel-kconfig (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/platforms/powernv/opal-core.c: In function 'opalcore_init':
>> arch/powerpc/platforms/powernv/opal-core.c:632:25: error: 'fadump_kobj' undeclared (first use in this function); did you mean 'fadump_ops'?
rc = sysfs_create_file(fadump_kobj, &opalcore_rel_attr.attr);
^~~~~~~~~~~
fadump_ops
arch/powerpc/platforms/powernv/opal-core.c:632:25: note: each undeclared identifier is reported only once for each function it appears in
vim +632 arch/powerpc/platforms/powernv/opal-core.c
591
592 static struct kobj_attribute opalcore_rel_attr = __ATTR(release_opalcore,
593 0200, NULL,
594 fadump_release_opalcore_store);
595
596 static int __init opalcore_init(void)
597 {
598 int rc = -1;
599
600 opalcore_config_init();
601
602 if (oc_conf == NULL)
603 return rc;
604
605 create_opalcore();
606
607 /*
608 * If oc_conf->opalcorebuf= is set in the 2nd kernel,
609 * then capture the dump.
610 */
611 if (!(is_opalcore_usable())) {
612 pr_err("Failed to export /sys/firmware/opal/core\n");
613 opalcore_cleanup();
614 return rc;
615 }
616
617 /* Set OPAL core file size */
618 opal_core_attr.size = oc_conf->opalcore_size;
619
620 /* Export OPAL core sysfs file */
621 rc = sysfs_create_bin_file(opal_kobj, &opal_core_attr);
622 if (rc != 0) {
623 pr_err("Failed to export /sys/firmware/opal/core\n");
624 opalcore_cleanup();
625 return rc;
626 }
627
628 /*
629 * Originally fadump_release_opalcore sysfs was part of kernel_kobj
630 * later moved to fadump_kobj and renamed to release_opalcore.
631 */
> 632 rc = sysfs_create_file(fadump_kobj, &opalcore_rel_attr.attr);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 15036 bytes --]
next prev parent reply other threads:[~2019-11-23 11:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 12:23 [PATCH v3 0/4] reorganize and add FADump sysfs files Sourabh Jain
2019-11-09 12:23 ` [PATCH v3 1/4] Documentation/ABI: add ABI documentation for /sys/kernel/fadump_* Sourabh Jain
2019-11-09 12:23 ` [PATCH v3 2/4] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files Sourabh Jain
2019-11-09 12:59 ` Michal Suchánek
2019-11-16 14:37 ` Sourabh Jain
2019-11-24 18:40 ` Michal Suchánek
2019-11-27 4:54 ` Sourabh Jain
2019-12-03 11:20 ` Sourabh Jain
2019-11-23 11:21 ` kbuild test robot [this message]
2019-11-09 12:23 ` [PATCH v3 3/4] Documentation/ABI: mark /sys/kernel/fadump_* sysfs files deprecated Sourabh Jain
2019-11-09 12:23 ` [PATCH v3 4/4] powerpc/fadump: sysfs for fadump memory reservation Sourabh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911231940.11VsnYpL%lkp@intel.com \
--to=lkp@intel.com \
--cc=corbet@lwn.net \
--cc=hbathini@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).