From: Christoph Hellwig <hch@infradead.org>
To: Haren Myneni <haren@linux.vnet.ibm.com>
Cc: devicetree@vger.kernel.org, mikey@neuling.org,
herbert@gondor.apana.org.au, npiggin@gmail.com,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 02/14] Revert "powerpc/powernv: remove the unused vas_win_paste_addr and vas_win_id functions"
Date: Wed, 27 Nov 2019 00:28:10 -0800 [thread overview]
Message-ID: <20191127082810.GA17097@infradead.org> (raw)
In-Reply-To: <1574816607.13250.6.camel@hbabu-laptop>
On Tue, Nov 26, 2019 at 05:03:27PM -0800, Haren Myneni wrote:
>
> This reverts commit 452d23c0f6bd97f2fd8a9691fee79b76040a0feb.
>
> User space send windows (NX GZIP compression) need vas_win_paste_addr()
> to mmap window paste address and vas_win_id() to get window ID when
> window address is given.
Even with your full series applied vas_win_paste_addr is entirely
unused, and vas_win_id is only used once in the same file it is defined.
So instead of this patch you should just open code vas_win_id in
init_winctx_for_txwin.
> +static inline u32 encode_pswid(int vasid, int winid)
> +{
> + u32 pswid = 0;
> +
> + pswid |= vasid << (31 - 7);
> + pswid |= winid;
> +
> + return pswid;
This can be simplified down to:
return (u32)winid | (vasid << (31 - 7));
next prev parent reply other threads:[~2019-11-27 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 1:03 [PATCH 02/14] Revert "powerpc/powernv: remove the unused vas_win_paste_addr and vas_win_id functions" Haren Myneni
2019-11-27 8:28 ` Christoph Hellwig [this message]
2019-11-27 9:20 ` Haren Myneni
2019-11-27 9:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127082810.GA17097@infradead.org \
--to=hch@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=haren@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=npiggin@gmail.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).