From: Mark Brown <broonie@kernel.org>
To: linux-arch@vger.kernel.org
Cc: linux-s390@vger.kernel.org, herbert@gondor.apana.org.au,
x86@kernel.org, Richard Henderson <richard.henderson@linaro.org>,
Mark Brown <broonie@kernel.org>, Borislav Petkov <bp@alien8.de>,
linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/10] Impveovements for random.h/archrandom.h
Date: Fri, 10 Jan 2020 14:54:12 +0000 [thread overview]
Message-ID: <20200110145422.49141-1-broonie@kernel.org> (raw)
This is a resend of a series from Richard Henderson last posted back in
November:
https://lore.kernel.org/linux-arm-kernel/20191106141308.30535-1-rth@twiddle.net/
Back then Borislav said they looked good and asked if he should take
them through the tip tree but things seem to have got lost since then.
Original cover letter:
During patch review for an addition of archrandom.h for arm64, it was
suggeted that the arch_random_get_* functions should be marked __must_check.
Which does sound like a good idea, since the by-reference integer output
may be uninitialized when the boolean result is false.
In addition, it turns out that arch_has_random() and arch_has_random_seed()
are not used, and not easy to support for arm64. Rather than cobble
something together that would not be testable, remove the interfaces
against some future accidental use.
In addition, I noticed a few other minor inconsistencies between the
different architectures, e.g. powerpc isn't using bool.
Change since v1:
* Remove arch_has_random, arch_has_random_seed.
Richard Henderson (10):
x86: Remove arch_has_random, arch_has_random_seed
powerpc: Remove arch_has_random, arch_has_random_seed
s390: Remove arch_has_random, arch_has_random_seed
linux/random.h: Remove arch_has_random, arch_has_random_seed
linux/random.h: Use false with bool
linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
x86: Mark archrandom.h functions __must_check
powerpc: Use bool in archrandom.h
powerpc: Mark archrandom.h functions __must_check
s390x: Mark archrandom.h functions __must_check
arch/powerpc/include/asm/archrandom.h | 27 +++++++++-----------------
arch/s390/include/asm/archrandom.h | 20 ++++---------------
arch/x86/include/asm/archrandom.h | 28 ++++++++++++---------------
include/linux/random.h | 24 ++++++++---------------
4 files changed, 33 insertions(+), 66 deletions(-)
--
2.20.1
next reply other threads:[~2020-01-10 14:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 14:54 Mark Brown [this message]
2020-01-10 14:54 ` [PATCH v2 01/10] x86: Remove arch_has_random, arch_has_random_seed Mark Brown
2020-01-10 14:54 ` [PATCH v2 02/10] powerpc: " Mark Brown
2020-01-10 14:54 ` [PATCH v2 03/10] s390: " Mark Brown
2020-01-10 14:54 ` [PATCH v2 04/10] linux/random.h: " Mark Brown
2020-01-10 14:54 ` [PATCH v2 05/10] linux/random.h: Use false with bool Mark Brown
2020-01-10 14:54 ` [PATCH v2 06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check Mark Brown
2020-01-10 14:54 ` [PATCH v2 07/10] x86: Mark archrandom.h " Mark Brown
2020-01-10 14:54 ` [PATCH v2 08/10] powerpc: Use bool in archrandom.h Mark Brown
2020-01-10 14:54 ` [PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check Mark Brown
2020-01-10 14:54 ` [PATCH v2 10/10] s390x: " Mark Brown
2020-01-10 15:51 ` [PATCH v2 00/10] Impveovements for random.h/archrandom.h Borislav Petkov
2020-01-10 17:05 ` Theodore Y. Ts'o
2020-01-20 17:26 ` Mark Brown
2020-01-20 17:59 ` Borislav Petkov
2020-01-25 17:46 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110145422.49141-1-broonie@kernel.org \
--to=broonie@kernel.org \
--cc=bp@alien8.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=richard.henderson@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).