From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alexandre Ghiti <alex@ghiti.fr>
Cc: Palmer Dabbelt <palmerdabbelt@google.com>,
Alexei Starovoitov <ast@kernel.org>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Paul Mackerras <paulus@samba.org>, Zong Li <zong.li@sifive.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Do not consider weak unresolved symbol relocations as bad
Date: Thu, 16 Jan 2020 10:39:32 +1100 [thread overview]
Message-ID: <20200116103932.2e603cf9@canb.auug.org.au> (raw)
In-Reply-To: <20200115204648.7179-1-alex@ghiti.fr>
[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]
Hi Alexandre,
Thanks for sorting this out. Just a few comments below.
On Wed, 15 Jan 2020 15:46:48 -0500 Alexandre Ghiti <alex@ghiti.fr> wrote:
>
>
> # Have Kbuild supply the path to objdump so we handle cross compilation.
^
"and nm"
> +# Remove from the bad relocations those that match an undefined weak symbol
> +# which will result in an absolute relocation to 0.
> +# Weak unresolved symbols are of that form in nm output:
> +# " w _binary__btf_vmlinux_bin_end"
> +undef_weak_symbols=$($nm "$vmlinux" | awk -e '$1 ~ /w/ { print $2 }')
> +
> +while IFS= read -r weak_symbol; do
> + bad_relocs="$(echo -n "$bad_relocs" | sed "/$weak_symbol/d")"
> +done <<< "$undef_weak_symbols"
This is not a bash script, and the above is a bashism :-(
Also, my version of awk (mawk) doesn't have a -e option.
How about something like :
undef_weak_symbols=$($nm "$vmlinux" | awk '$1 ~ /w/ { print $2 }')
if [ "$undef_weak_symbols" ]; then
bad_relocs="$(echo "$bad_relocs" | grep -F -w -v "$undef_weak_symbols")"
fi
Or do this near the top and add the grep to the others.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-15 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:46 [PATCH] powerpc: Do not consider weak unresolved symbol relocations as bad Alexandre Ghiti
2020-01-15 23:39 ` Stephen Rothwell [this message]
2020-01-16 19:49 ` Alex Ghiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116103932.2e603cf9@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=alex@ghiti.fr \
--cc=ast@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=palmerdabbelt@google.com \
--cc=paulus@samba.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).