From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248C4C33CB6 for ; Fri, 17 Jan 2020 09:01:56 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F82D21835 for ; Fri, 17 Jan 2020 09:01:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F82D21835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47zZnD5TcLzDqcj for ; Fri, 17 Jan 2020 20:01:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=permerror (SPF Permanent Error: Unknown mechanism found: ip:192.40.192.88/32) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47zZkn1m9XzDqZR for ; Fri, 17 Jan 2020 19:59:44 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 00H8ws29002697; Fri, 17 Jan 2020 02:58:54 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 00H8wpV1002692; Fri, 17 Jan 2020 02:58:51 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 17 Jan 2020 02:58:51 -0600 From: Segher Boessenkool To: Christophe Leroy Subject: Re: [RFC PATCH v4 00/11] powerpc: switch VDSO to C implementation. Message-ID: <20200117085851.GS3191@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nathanl@linux.ibm.com, arnd@arndb.de, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Paul Mackerras , luto@kernel.org, tglx@linutronix.de, vincenzo.frascino@arm.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi! On Thu, Jan 16, 2020 at 05:58:24PM +0000, Christophe Leroy wrote: > On a powerpc8xx, with current powerpc/32 ASM VDSO: > > gettimeofday: vdso: 907 nsec/call > clock-getres-realtime: vdso: 484 nsec/call > clock-gettime-realtime: vdso: 899 nsec/call > > The first patch adds VDSO generic C support without any changes to common code. > Performance is as follows: > > gettimeofday: vdso: 1211 nsec/call > clock-getres-realtime: vdso: 722 nsec/call > clock-gettime-realtime: vdso: 1216 nsec/call > > Then a few changes in the common code have allowed performance improvement. At > the end of the series we have: > > gettimeofday: vdso: 974 nsec/call > clock-getres-realtime: vdso: 545 nsec/call > clock-gettime-realtime: vdso: 941 nsec/call > > The final result is rather close to pure ASM VDSO: > * 7% more on gettimeofday (9 cycles) > * 5% more on clock-gettime-realtime (6 cycles) > * 12% more on clock-getres-realtime (8 cycles) Nice! Much better. It should be tested on more representative hardware, too, but this looks promising alright :-) Segher