From: Baoquan He <bhe@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Sachin Sant <sachinp@linux.vnet.ibm.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>,
linux-nvdimm@lists.01.org
Subject: Re: [5.6.0-rc7] Kernel crash while running ndctl tests
Date: Tue, 24 Mar 2020 18:14:01 +0800 [thread overview]
Message-ID: <20200324101401.GA9942@MiWiFi-R3L-srv> (raw)
In-Reply-To: <33E32320-C371-4A41-A3E1-4B9D2DDAFBFC@linux.vnet.ibm.com>
On 03/24/20 at 03:06pm, Sachin Sant wrote:
>
>
> > On 24-Mar-2020, at 2:45 PM, Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> wrote:
> >
> > Sachin Sant <sachinp@linux.vnet.ibm.com> writes:
> >
> >> While running ndctl[1] tests against 5.6.0-rc7 following crash is encountered.
> >>
> >> Bisect leads me to commit d41e2f3bd546
> >> mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case
> >>
> >> Reverting this commit helps and the tests complete without any crash.
> >
> >
> > Can you try this change?
> >
> > diff --git a/mm/sparse.c b/mm/sparse.c
> > index aadb7298dcef..3012d1f3771a 100644
> > --- a/mm/sparse.c
> > +++ b/mm/sparse.c
> > @@ -781,6 +781,8 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages,
> > ms->usage = NULL;
> > }
> > memmap = sparse_decode_mem_map(ms->section_mem_map, section_nr);
> > + /* Mark the section invalid */
> > + ms->section_mem_map &= ~SECTION_HAS_MEM_MAP;
> > }
> >
> > if (section_is_early && memmap)
> >
>
> This patch works for me. The test ran successfully without any crash/failure.
Hi Aneesh,
Could you make a formal patch to post, since Sachin has tested and
confirmed it works?
>
> Thanks
> -Sachin
>
> > a pfn_valid check involves pnf_section_valid() check if section is
> > having MEM_MAP. In this case we did end up setting the ms->uage = NULL.
> > So when we do that tupdate the section to not have MEM_MAP.
> >
> > -aneesh
>
prev parent reply other threads:[~2020-03-24 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 5:55 [5.6.0-rc7] Kernel crash while running ndctl tests Sachin Sant
2020-03-24 7:07 ` Baoquan He
2020-03-24 7:45 ` Sachin Sant
2020-03-24 9:15 ` Aneesh Kumar K.V
2020-03-24 9:36 ` Sachin Sant
2020-03-24 10:14 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324101401.GA9942@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sachinp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).