From: Kajol Jain <kjain@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
suka@us.ibm.com, nathanl@linux.ibm.com
Cc: ravi.bangoria@linux.ibm.com, maddy@linux.vnet.ibm.com,
mpetlan@redhat.com, peterz@infradead.org,
gregkh@linuxfoundation.org, alexander.shishkin@linux.intel.com,
kjain@linux.ibm.com, anju@linux.vnet.ibm.com,
mamatha4@linux.vnet.ibm.com, namhyung@kernel.org,
mingo@kernel.org
Subject: [PATCH v9 2/5] powerpc/hv-24x7: Add rtas call in hv-24x7 driver to get processor details
Date: Mon, 18 May 2020 17:34:49 +0530 [thread overview]
Message-ID: <20200518120452.15082-3-kjain@linux.ibm.com> (raw)
In-Reply-To: <20200518120452.15082-1-kjain@linux.ibm.com>
For hv_24x7 socket/chip level events, specific chip-id to which
the data requested should be added as part of pmu events.
But number of chips/socket in the system details are not exposed.
Patch implements read_sys_info_pseries() to get system
parameter values like number of sockets, cores per chip and
chips per socket. Rtas_call with token "PROCESSOR_MODULE_INFO"
is used to get these values.
Sub-sequent patch exports these values via sysfs.
Patch also make these parameters default to 1.
Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
---
arch/powerpc/include/asm/rtas.h | 6 +++
arch/powerpc/perf/hv-24x7.c | 72 +++++++++++++++++++++++++++++++++
2 files changed, 78 insertions(+)
diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h
index 3c1887351c71..a5b302180041 100644
--- a/arch/powerpc/include/asm/rtas.h
+++ b/arch/powerpc/include/asm/rtas.h
@@ -483,5 +483,11 @@ static inline void rtas_initialize(void) { };
extern int call_rtas(const char *, int, int, unsigned long *, ...);
+#ifdef CONFIG_HV_PERF_CTRS
+void read_sys_info_pseries(void);
+#else
+static inline void read_sys_info_pseries(void) { }
+#endif
+
#endif /* __KERNEL__ */
#endif /* _POWERPC_RTAS_H */
diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
index 48e8f4b17b91..b8625058c2aa 100644
--- a/arch/powerpc/perf/hv-24x7.c
+++ b/arch/powerpc/perf/hv-24x7.c
@@ -20,6 +20,7 @@
#include <asm/io.h>
#include <linux/byteorder/generic.h>
+#include <asm/rtas.h>
#include "hv-24x7.h"
#include "hv-24x7-catalog.h"
#include "hv-common.h"
@@ -57,6 +58,75 @@ static bool is_physical_domain(unsigned domain)
}
}
+/*
+ * The Processor Module Information system parameter allows transferring
+ * of certain processor module information from the platform to the OS.
+ * Refer PAPR+ document to get parameter token value as '43'.
+ */
+
+#define PROCESSOR_MODULE_INFO 43
+
+static u32 phys_sockets; /* Physical sockets */
+static u32 phys_chipspersocket; /* Physical chips per socket*/
+static u32 phys_coresperchip; /* Physical cores per chip */
+
+
+/*
+ * read_sys_info_pseries()
+ * Retrieve the number of sockets, chips per socket and cores per
+ * chip details through the get-system-parameter rtas call.
+ */
+void read_sys_info_pseries(void)
+{
+ int call_status, len, ntypes;
+ char *rtas_local_data_buf = kmalloc(RTAS_DATA_BUF_SIZE, GFP_KERNEL);
+
+ if (!rtas_local_data_buf) {
+ printk(KERN_ERR "%s %s kmalloc failure at line %d\n",
+ __FILE__, __func__, __LINE__);
+ return;
+ }
+
+ /*
+ * Making system parameter: chips per socket, sockets and cores per chip
+ * default to 1.
+ */
+ spin_lock(&rtas_data_buf_lock);
+ phys_sockets = 1;
+ phys_chipspersocket = 1;
+ phys_coresperchip = 1;
+ memset(rtas_data_buf, 0, RTAS_DATA_BUF_SIZE);
+
+ call_status = rtas_call(rtas_token("ibm,get-system-parameter"), 3, 1,
+ NULL,
+ PROCESSOR_MODULE_INFO,
+ __pa(rtas_data_buf),
+ RTAS_DATA_BUF_SIZE);
+
+ memcpy(rtas_local_data_buf, rtas_data_buf, RTAS_DATA_BUF_SIZE);
+ rtas_local_data_buf[RTAS_DATA_BUF_SIZE - 1] = '\0';
+
+ spin_unlock(&rtas_data_buf_lock);
+
+ if (call_status != 0)
+ pr_err("Error calling get-system-parameter %d\n", call_status);
+ else {
+ len = be16_to_cpup((__be16 *)&rtas_local_data_buf[0]);
+ if (len < 8)
+ return;
+
+ ntypes = be16_to_cpup((__be16 *)&rtas_local_data_buf[2]);
+
+ if (!ntypes)
+ return;
+ phys_sockets = be16_to_cpup((__be16 *)&rtas_local_data_buf[4]);
+ phys_chipspersocket = be16_to_cpup((__be16 *)&rtas_local_data_buf[6]);
+ phys_coresperchip = be16_to_cpup((__be16 *)&rtas_local_data_buf[8]);
+ }
+
+ kfree(rtas_local_data_buf);
+}
+
/* Domains for which more than one result element are returned for each event. */
static bool domain_needs_aggregation(unsigned int domain)
{
@@ -1605,6 +1675,8 @@ static int hv_24x7_init(void)
if (r)
return r;
+ read_sys_info_pseries();
+
return 0;
}
--
2.18.2
next prev parent reply other threads:[~2020-05-18 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 12:04 [PATCH v9 0/5] powerpc/hv-24x7: Expose chip/sockets info to add json file metric support for the hv_24x7 socket/chip level events Kajol Jain
2020-05-18 12:04 ` [PATCH v9 1/5] powerpc/perf/hv-24x7: Fix inconsistent output values incase multiple hv-24x7 events run Kajol Jain
2020-05-18 12:04 ` Kajol Jain [this message]
2020-05-18 12:04 ` [PATCH v9 3/5] powerpc/hv-24x7: Add sysfs files inside hv-24x7 device to show processor details Kajol Jain
2020-05-18 12:04 ` [PATCH v9 4/5] Documentation/ABI: Add ABI documentation for chips and sockets Kajol Jain
2020-05-18 12:04 ` [PATCH v9 5/5] powerpc/pseries: Update hv-24x7 information after migration Kajol Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518120452.15082-3-kjain@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mamatha4@linux.vnet.ibm.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathanl@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=suka@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).