From: Qian Cai <cai@lca.pw>
To: Peter Zijlstra <peterz@infradead.org>
Cc: daniel.thompson@linaro.org, andrew.cooper3@citrix.com,
bigeasy@linutronix.de, x86@kernel.org,
linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com,
luto@amacapital.net, Lai Jiangshan <laijs@linux.alibaba.com>,
rostedt@goodmis.org, a.darwish@linutronix.de, tglx@linutronix.de,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 11/14] x86/entry: Clarify irq_{enter,exit}_rcu()
Date: Tue, 2 Jun 2020 14:47:20 -0400 [thread overview]
Message-ID: <20200602184720.GA1607@lca.pw> (raw)
In-Reply-To: <20200602150511.GH706478@hirez.programming.kicks-ass.net>
On Tue, Jun 02, 2020 at 05:05:11PM +0200, Peter Zijlstra wrote:
> On Tue, Jun 02, 2020 at 10:42:35AM -0400, Qian Cai wrote:
>
> > Reverted this commit fixed the POWER9 boot warning,
>
> ARGH, I'm an idiot. Please try this instead:
>
>
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index a3eb6eba8c41..c4201b7f42b1 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -438,7 +438,7 @@ void irq_exit_rcu(void)
> */
> void irq_exit(void)
> {
> - irq_exit_rcu();
> + __irq_exit_rcu();
> rcu_irq_exit();
> /* must be last! */
> lockdep_hardirq_exit();
This works fine.
prev parent reply other threads:[~2020-06-02 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200529212728.795169701@infradead.org>
[not found] ` <20200529213321.359433429@infradead.org>
2020-06-02 14:42 ` [PATCH 11/14] x86/entry: Clarify irq_{enter,exit}_rcu() Qian Cai
2020-06-02 15:05 ` Peter Zijlstra
2020-06-02 18:47 ` Qian Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602184720.GA1607@lca.pw \
--to=cai@lca.pw \
--cc=a.darwish@linutronix.de \
--cc=andrew.cooper3@citrix.com \
--cc=bigeasy@linutronix.de \
--cc=daniel.thompson@linaro.org \
--cc=laijs@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).