From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916F6C433E1 for ; Fri, 17 Jul 2020 04:53:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 493BD20684 for ; Fri, 17 Jul 2020 04:53:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 493BD20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4B7Jff3BGwzDqQy for ; Fri, 17 Jul 2020 14:53:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=ego@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B7Jcp6tW4zDqN0 for ; Fri, 17 Jul 2020 14:51:54 +1000 (AEST) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06H4WKvJ054745; Fri, 17 Jul 2020 00:51:50 -0400 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 32792xw7b8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Jul 2020 00:51:49 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 06H4jAI6010445; Fri, 17 Jul 2020 04:51:48 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma05wdc.us.ibm.com with ESMTP id 327529e7af-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Jul 2020 04:51:48 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 06H4pk4h57803202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Jul 2020 04:51:46 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F88413604F; Fri, 17 Jul 2020 04:51:46 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA7D6136051; Fri, 17 Jul 2020 04:51:45 +0000 (GMT) Received: from sofia.ibm.com (unknown [9.199.61.65]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 17 Jul 2020 04:51:45 +0000 (GMT) Received: by sofia.ibm.com (Postfix, from userid 1000) id D47AB2E3026; Fri, 17 Jul 2020 10:21:40 +0530 (IST) Date: Fri, 17 Jul 2020 10:21:40 +0530 From: Gautham R Shenoy To: Srikar Dronamraju Subject: Re: [PATCH 01/11] powerpc/smp: Cache node for reuse Message-ID: <20200717045140.GA25851@in.ibm.com> References: <20200714043624.5648-1-srikar@linux.vnet.ibm.com> <20200714043624.5648-2-srikar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714043624.5648-2-srikar@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-16_11:2020-07-16, 2020-07-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 bulkscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007170029 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ego@linux.vnet.ibm.com Cc: Nathan Lynch , Gautham R Shenoy , Oliver OHalloran , Michael Neuling , Michael Ellerman , Anton Blanchard , linuxppc-dev , Nick Piggin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 14, 2020 at 10:06:14AM +0530, Srikar Dronamraju wrote: > While cpu_to_node is inline function with access to per_cpu variable. > However when using repeatedly, it may be cleaner to cache it in a local > variable. > > Also fix a build error in a some weird config. > "error: _numa_cpu_lookup_table_ undeclared" > > No functional change > > Cc: linuxppc-dev > Cc: Michael Ellerman > Cc: Nick Piggin > Cc: Oliver OHalloran > Cc: Nathan Lynch > Cc: Michael Neuling > Cc: Anton Blanchard > Cc: Gautham R Shenoy > Cc: Vaidyanathan Srinivasan > Signed-off-by: Srikar Dronamraju LGTM. Reviewed-by: Gautham R. Shenoy > --- > arch/powerpc/kernel/smp.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 73199470c265..680c0edcc59d 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -843,7 +843,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > DBG("smp_prepare_cpus\n"); > > - /* > + /* > * setup_cpu may need to be called on the boot cpu. We havent > * spun any cpus up but lets be paranoid. > */ > @@ -854,20 +854,24 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > cpu_callin_map[boot_cpuid] = 1; > > for_each_possible_cpu(cpu) { > + int node = cpu_to_node(cpu); > + > zalloc_cpumask_var_node(&per_cpu(cpu_sibling_map, cpu), > - GFP_KERNEL, cpu_to_node(cpu)); > + GFP_KERNEL, node); > zalloc_cpumask_var_node(&per_cpu(cpu_l2_cache_map, cpu), > - GFP_KERNEL, cpu_to_node(cpu)); > + GFP_KERNEL, node); > zalloc_cpumask_var_node(&per_cpu(cpu_core_map, cpu), > - GFP_KERNEL, cpu_to_node(cpu)); > + GFP_KERNEL, node); > +#ifdef CONFIG_NEED_MULTIPLE_NODES > /* > * numa_node_id() works after this. > */ > if (cpu_present(cpu)) { > - set_cpu_numa_node(cpu, numa_cpu_lookup_table[cpu]); > - set_cpu_numa_mem(cpu, > - local_memory_node(numa_cpu_lookup_table[cpu])); > + node = numa_cpu_lookup_table[cpu]; > + set_cpu_numa_node(cpu, node); > + set_cpu_numa_mem(cpu, local_memory_node(node)); > } > +#endif > } > > /* Init the cpumasks so the boot CPU is related to itself */ > -- > 2.17.1 >