LinuxPPC-Dev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net] ibmvnic: Fix IRQ mapping disposal in error path
@ 2020-07-29 21:36 Thomas Falcon
  2020-07-29 22:28 ` Jakub Kicinski
  2020-07-29 22:36 ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Falcon @ 2020-07-29 21:36 UTC (permalink / raw)
  To: netdev; +Cc: drt, Thomas Falcon, linuxppc-dev

RX queue IRQ mappings are disposed in both the TX IRQ and RX IRQ
error paths. Fix this and dispose of TX IRQ mappings correctly in
case of an error.

Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 0fd7eae..5afb3c9 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -3206,7 +3206,7 @@ static int init_sub_crq_irqs(struct ibmvnic_adapter *adapter)
 req_tx_irq_failed:
 	for (j = 0; j < i; j++) {
 		free_irq(adapter->tx_scrq[j]->irq, adapter->tx_scrq[j]);
-		irq_dispose_mapping(adapter->rx_scrq[j]->irq);
+		irq_dispose_mapping(adapter->tx_scrq[j]->irq);
 	}
 	release_sub_crqs(adapter, 1);
 	return rc;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net] ibmvnic: Fix IRQ mapping disposal in error path
  2020-07-29 21:36 [PATCH net] ibmvnic: Fix IRQ mapping disposal in error path Thomas Falcon
@ 2020-07-29 22:28 ` Jakub Kicinski
  2020-07-29 22:37   ` Thomas Falcon
  2020-07-29 22:36 ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2020-07-29 22:28 UTC (permalink / raw)
  To: Thomas Falcon; +Cc: drt, netdev, linuxppc-dev

On Wed, 29 Jul 2020 16:36:32 -0500 Thomas Falcon wrote:
> RX queue IRQ mappings are disposed in both the TX IRQ and RX IRQ
> error paths. Fix this and dispose of TX IRQ mappings correctly in
> case of an error.
> 
> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>

Thomas, please remember about Fixes tags (for networking patches, 
at least):

Fixes: ea22d51a7831 ("ibmvnic: simplify and improve driver probe function")

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net] ibmvnic: Fix IRQ mapping disposal in error path
  2020-07-29 21:36 [PATCH net] ibmvnic: Fix IRQ mapping disposal in error path Thomas Falcon
  2020-07-29 22:28 ` Jakub Kicinski
@ 2020-07-29 22:36 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-07-29 22:36 UTC (permalink / raw)
  To: tlfalcon; +Cc: drt, netdev, linuxppc-dev

From: Thomas Falcon <tlfalcon@linux.ibm.com>
Date: Wed, 29 Jul 2020 16:36:32 -0500

> RX queue IRQ mappings are disposed in both the TX IRQ and RX IRQ
> error paths. Fix this and dispose of TX IRQ mappings correctly in
> case of an error.
> 
> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>

Applied with Fixes: tag added and queued up for -stable.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net] ibmvnic: Fix IRQ mapping disposal in error path
  2020-07-29 22:28 ` Jakub Kicinski
@ 2020-07-29 22:37   ` Thomas Falcon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Falcon @ 2020-07-29 22:37 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: drt, netdev, linuxppc-dev


On 7/29/20 5:28 PM, Jakub Kicinski wrote:
> On Wed, 29 Jul 2020 16:36:32 -0500 Thomas Falcon wrote:
>> RX queue IRQ mappings are disposed in both the TX IRQ and RX IRQ
>> error paths. Fix this and dispose of TX IRQ mappings correctly in
>> case of an error.
>>
>> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
> Thomas, please remember about Fixes tags (for networking patches,
> at least):
>
> Fixes: ea22d51a7831 ("ibmvnic: simplify and improve driver probe function")

Sorry, Jakub, I will try not to forget next time. Thanks.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 21:36 [PATCH net] ibmvnic: Fix IRQ mapping disposal in error path Thomas Falcon
2020-07-29 22:28 ` Jakub Kicinski
2020-07-29 22:37   ` Thomas Falcon
2020-07-29 22:36 ` David Miller

LinuxPPC-Dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \
		linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org
	public-inbox-index linuxppc-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git