From: Ram Pai <linuxram@us.ibm.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: ldufour@linux.ibm.com, linux-doc@vger.kernel.org, corbet@lwn.net,
kvm-ppc@vger.kernel.org, bharata@linux.ibm.com,
sathnaga@linux.vnet.ibm.com, sukadev@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org, david@gibson.dropbear.id.au
Subject: [PATCH] KVM: PPC: Book3S HV: Define H_PAGE_IN_NONSHARED for H_SVM_PAGE_IN hcall
Date: Thu, 30 Jul 2020 16:21:01 -0700 [thread overview]
Message-ID: <20200730232101.GB5882@oc0525413822.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2007301231140.2548@hadrien>
H_SVM_PAGE_IN hcall takes a flag parameter. This parameter specifies the
way in which a page will be treated. H_PAGE_IN_NONSHARED indicates
that the page will be shared with the Secure VM, and H_PAGE_IN_SHARED
indicates that the page will not be shared but its contents will
be copied.
However H_PAGE_IN_NONSHARED is not defined in the header file, though
it is defined and documented in the API captured in
Documentation/powerpc/ultravisor.rst
Define H_PAGE_IN_NONSHARED in the header file.
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: Ram Pai <linuxram@us.ibm.com>
---
arch/powerpc/include/asm/hvcall.h | 4 +++-
arch/powerpc/kvm/book3s_hv_uvmem.c | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
index e90c073..43e3f8d 100644
--- a/arch/powerpc/include/asm/hvcall.h
+++ b/arch/powerpc/include/asm/hvcall.h
@@ -343,7 +343,9 @@
#define H_COPY_TOFROM_GUEST 0xF80C
/* Flags for H_SVM_PAGE_IN */
-#define H_PAGE_IN_SHARED 0x1
+#define H_PAGE_IN_NONSHARED 0x0 /* Page is not shared with the UV */
+#define H_PAGE_IN_SHARED 0x1 /* Page is shared with UV */
+#define H_PAGE_IN_MASK 0x1
/* Platform-specific hcalls used by the Ultravisor */
#define H_SVM_PAGE_IN 0xEF00
diff --git a/arch/powerpc/kvm/book3s_hv_uvmem.c b/arch/powerpc/kvm/book3s_hv_uvmem.c
index 2dde0fb..2806983 100644
--- a/arch/powerpc/kvm/book3s_hv_uvmem.c
+++ b/arch/powerpc/kvm/book3s_hv_uvmem.c
@@ -947,12 +947,13 @@ unsigned long kvmppc_h_svm_page_in(struct kvm *kvm, unsigned long gpa,
if (page_shift != PAGE_SHIFT)
return H_P3;
- if (flags & ~H_PAGE_IN_SHARED)
+ if (flags & ~H_PAGE_IN_MASK)
return H_P2;
if (flags & H_PAGE_IN_SHARED)
return kvmppc_share_page(kvm, gpa, page_shift);
+ /* handle H_PAGE_IN_NONSHARED */
ret = H_PARAMETER;
srcu_idx = srcu_read_lock(&kvm->srcu);
mmap_read_lock(kvm->mm);
--
1.8.3.1
--
Ram Pai
next prev parent reply other threads:[~2020-07-30 23:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:35 Documentation/powerpc: Ultravisor API Julia Lawall
2020-07-30 16:48 ` Ram Pai
2020-07-30 23:21 ` Ram Pai [this message]
2020-07-31 4:33 ` [PATCH] KVM: PPC: Book3S HV: Define H_PAGE_IN_NONSHARED for H_SVM_PAGE_IN hcall Bharata B Rao
2020-07-31 8:10 ` Ram Pai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730232101.GB5882@oc0525413822.ibm.com \
--to=linuxram@us.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=david@gibson.dropbear.id.au \
--cc=julia.lawall@inria.fr \
--cc=kvm-ppc@vger.kernel.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sathnaga@linux.vnet.ibm.com \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).