From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Felipe Balbi <balbi@kernel.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
linux-usb@vger.kernel.org,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Wei Xu" <xuwei5@hisilicon.com>,
linux-samsung-soc@vger.kernel.org,
"Kevin Hilman" <khilman@baylibre.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>, "Kukjin Kim" <kgene@kernel.org>,
"Andy Gross" <agross@kernel.org>,
linux-arm-msm@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
devicetree@vger.kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
"Mathias Nyman" <mathias.nyman@intel.com>,
linux-kernel@vger.kernel.org,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Rob Herring" <robh+dt@kernel.org>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Roger Quadros" <rogerq@ti.com>,
linux-mips@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
linuxppc-dev@lists.ozlabs.org,
"Patrice Chotard" <patrice.chotard@st.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Li Yang" <leoyang.li@nxp.com>,
"Manu Gautam" <mgautam@codeaurora.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>
Subject: Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name
Date: Thu, 15 Oct 2020 16:53:17 +0300 [thread overview]
Message-ID: <20201015135317.5jsrrqmwmdz4lnzm@mobilestation> (raw)
In-Reply-To: <875z7blrqu.fsf@kernel.org>
On Thu, Oct 15, 2020 at 01:15:37PM +0300, Felipe Balbi wrote:
> Serge Semin <Sergey.Semin@baikalelectronics.ru> writes:
>
> > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote:
> >>
> >> Hi Serge,
> >>
> >> Serge Semin <Sergey.Semin@baikalelectronics.ru> writes:
> >> > In accordance with the DWC USB3 bindings the corresponding node name is
> >> > suppose to comply with Generic USB HCD DT schema, which requires the USB
> >>
> >
> >> DWC3 is not a simple HDC, though.
> >
> > Yeah, strictly speaking it is equipped with a lot of vendor-specific stuff,
> > which are tuned by the DWC USB3 driver in the kernel. But after that the
> > controller is registered as xhci-hcd device so it's serviced by the xHCI driver,
>
> in Dual-role or host-only builds, that's correct. We can also have
> peripheral-only builds (both SW or HW versions) which means xhci isn't
> even in the picture.
Hm, good point. In that case perhaps we'll need to apply the xHCI DT schema
conditionally. Like this:
- allOf:
- - $ref: usb-xhci.yaml#
+ allOf:
+ - if:
+ properties:
+ dr_mode:
+ const: peripheral
+ then:
+ $ref: usb-hcd.yaml#
+ else:
+ $ref: usb-xhci.yaml#
Note, we need to have the peripheral device being compatible with the
usb-hcd.yaml schema to support the maximum-speed, dr_mode properties and to
comply with the USB node naming constraint.
-Sergey
>
> --
> balbi
next prev parent reply other threads:[~2020-10-15 13:59 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 10:13 [PATCH 00/20] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema Serge Semin
2020-10-14 10:13 ` [PATCH 01/20] dt-bindings: usb: usb-hcd: Convert generic USB properties to " Serge Semin
2020-10-16 18:33 ` Rob Herring
2020-10-14 10:13 ` [PATCH 02/20] dt-bindings: usb: usb-hcd: Add "otg-rev" property restriction Serge Semin
2020-10-16 18:33 ` Rob Herring
2020-10-14 10:13 ` [PATCH 03/20] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types Serge Semin
2020-10-16 18:34 ` Rob Herring
2020-10-14 10:13 ` [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property Serge Semin
2020-10-14 13:27 ` Rob Herring
2020-10-14 17:27 ` Serge Semin
2020-10-16 15:44 ` Rob Herring
2020-10-16 18:47 ` Rob Herring
2020-10-14 10:13 ` [PATCH 05/20] dt-bindings: usb: usb-hcd: Add generic "usb-phy" property Serge Semin
2020-10-16 18:47 ` Rob Herring
2020-10-14 10:13 ` [PATCH 06/20] dt-bindings: usb: Convert xHCI bindings to DT schema Serge Semin
2020-10-16 18:49 ` Rob Herring
2020-10-14 10:13 ` [PATCH 07/20] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device Serge Semin
2020-10-15 16:39 ` Florian Fainelli
2020-10-16 18:49 ` Rob Herring
2020-10-14 10:13 ` [PATCH 08/20] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file Serge Semin
2020-10-16 18:50 ` Rob Herring
2020-10-20 4:42 ` Yoshihiro Shimoda
2020-10-14 10:13 ` [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Serge Semin
2020-10-14 13:32 ` Rob Herring
2020-10-14 17:37 ` Serge Semin
2020-10-14 10:13 ` [PATCH 10/20] dt-bindings: usb: dwc3: Add interrupt-names property support Serge Semin
2020-10-16 18:50 ` Rob Herring
2020-10-14 10:13 ` [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys, dwc3 compatible string Serge Semin
2020-10-14 20:18 ` [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 " Krzysztof Kozlowski
2020-10-14 21:35 ` Serge Semin
2020-10-16 18:53 ` Rob Herring
2020-10-19 16:22 ` Serge Semin
2020-10-14 10:13 ` [PATCH 12/20] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions Serge Semin
2020-10-16 18:54 ` Rob Herring
2020-10-14 10:13 ` [PATCH 13/20] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions Serge Semin
2020-10-16 18:54 ` Rob Herring
2020-10-14 10:13 ` [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value Serge Semin
2020-10-16 18:54 ` Rob Herring
2020-10-16 20:46 ` Martin Blumenstingl
2020-10-14 10:13 ` [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin
2020-10-16 18:54 ` Rob Herring
2020-10-16 20:47 ` Martin Blumenstingl
2020-10-14 10:13 ` [PATCH 16/20] dt-bindings: usb: keystone-dwc3: Validate DWC3 sub-node Serge Semin
2020-10-16 18:55 ` Rob Herring
2020-10-14 10:13 ` [PATCH 17/20] dt-bindings: usb: qcom,dwc3: " Serge Semin
2020-10-16 18:55 ` [PATCH 17/20] dt-bindings: usb: qcom, dwc3: " Rob Herring
2020-10-14 10:14 ` [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name Serge Semin
2020-10-14 18:00 ` Florian Fainelli
2020-10-14 18:11 ` Serge Semin
2020-10-14 18:41 ` Florian Fainelli
2020-10-14 21:21 ` Serge Semin
2020-10-14 18:56 ` Paul Cercueil
2020-10-14 19:12 ` Alexey Brodkin
2020-10-15 8:05 ` Amelie DELAUNAY
2020-10-15 16:37 ` Florian Fainelli
2020-10-16 7:08 ` Alexandre Torgue
2020-10-16 8:52 ` Serge Semin
2020-10-14 10:14 ` [PATCH 19/20] arch: dts: Fix xHCI " Serge Semin
2020-10-14 10:14 ` [PATCH 20/20] arch: dts: Fix DWC USB3 " Serge Semin
2020-10-14 10:33 ` Krzysztof Kozlowski
2020-10-14 17:16 ` Serge Semin
2020-10-14 20:04 ` Krzysztof Kozlowski
2020-10-14 23:51 ` Serge Semin
2020-10-15 6:14 ` Krzysztof Kozlowski
2020-10-15 14:15 ` Serge Semin
2020-10-14 14:09 ` Felipe Balbi
2020-10-14 14:37 ` Serge Semin
2020-10-14 18:35 ` Rob Herring
2020-10-14 21:22 ` Serge Semin
2020-10-15 10:15 ` Felipe Balbi
2020-10-15 13:53 ` Serge Semin [this message]
2020-10-15 14:04 ` Maxime Ripard
2020-10-14 17:39 ` [PATCH 00/20] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015135317.5jsrrqmwmdz4lnzm@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=agross@kernel.org \
--cc=andrew@lunn.ch \
--cc=balbi@kernel.org \
--cc=bcousson@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mathias.nyman@intel.com \
--cc=mgautam@codeaurora.org \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=patrice.chotard@st.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=wens@csie.org \
--cc=xuwei5@hisilicon.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).