linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: linuxppc-dev@lists.ozlabs.org
Cc: "Rob Herring" <robh@kernel.org>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Marc Zyngier" <maz@kernel.org>,
	linux-kernel@vger.kernel.org, "Qian Cai" <cai@lca.pw>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Frederic Barrat" <fbarrat@linux.ibm.com>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Michal Suchánek" <msuchanek@suse.de>
Subject: [RFC PATCH kernel 0/2] irq: Add reference counting to IRQ mappings
Date: Tue, 27 Oct 2020 20:06:53 +1100	[thread overview]
Message-ID: <20201027090655.14118-1-aik@ozlabs.ru> (raw)


This is an attempt to fix a bug with PCI hot unplug with
a bunch of PCIe bridges and devices sharing INTx.

This did not hit us before as even if we did not
call irq_domain_ops::unmap, the platform (PowerVM) would not
produce an error but with POWER9's XIVE interrupt controller
there is an error if unmap is not called at all (2/2 fixes that)
or an error if we unmapped an interrupt which is still in use
by another device (1/2 fixes that).

One way of fixing that is doing reference counting in
the POWERPC code but since there is a kobj in irq_desc
already, I thought I'll give it a try first.


This is based on sha1
4525c8781ec0 Linus Torvalds "scsi: qla2xxx: remove incorrect sparse #ifdef".

Please comment. Thanks.



Alexey Kardashevskiy (1):
  irq: Add reference counting to IRQ mappings

Oliver O'Halloran (1):
  powerpc/pci: Remove LSI mappings on device teardown

 arch/powerpc/kernel/pci-common.c | 21 +++++++++++++++++++
 kernel/irq/irqdesc.c             | 35 +++++++++++++++++++++-----------
 kernel/irq/irqdomain.c           | 27 ++++++++++++------------
 3 files changed, 57 insertions(+), 26 deletions(-)

-- 
2.17.1


             reply	other threads:[~2020-10-27  9:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27  9:06 Alexey Kardashevskiy [this message]
2020-10-27  9:06 ` [RFC PATCH kernel 1/2] irq: Add reference counting to IRQ mappings Alexey Kardashevskiy
2020-10-27 16:09   ` Marc Zyngier
2020-10-29  5:04     ` Alexey Kardashevskiy
2020-10-27  9:06 ` [RFC PATCH kernel 2/2] powerpc/pci: Remove LSI mappings on device teardown Alexey Kardashevskiy
2020-11-13 12:06   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027090655.14118-1-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=cai@lca.pw \
    --cc=clg@kaod.org \
    --cc=fbarrat@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maz@kernel.org \
    --cc=msuchanek@suse.de \
    --cc=oohall@gmail.com \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).