From: Petr Mladek <pmladek@suse.com>
To: Santosh Sivaraj <santosh@fossix.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
bala24@linux.ibm.com, Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RESEND PATCH] kernel/watchdog: Fix watchdog_allowed_mask not used warning
Date: Tue, 3 Nov 2020 11:15:16 +0100 [thread overview]
Message-ID: <20201103101516.GM20201@alley> (raw)
In-Reply-To: <214be993-96ec-82b0-b841-c80f7e7faefb@csgroup.eu>
On Tue 2020-11-03 10:55:11, Christophe Leroy wrote:
>
>
> Le 03/11/2020 à 10:32, Santosh Sivaraj a écrit :
> > Define watchdog_allowed_mask only when SOFTLOCKUP_DETECTOR is enabled.
> >
> > Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
>
> I think maybe you should add a Fixes: tag (Towards https://github.com/linuxppc/linux/commit/7feeb9cd ?)
>
> And copy Thomas (tglx)
And also Andrew that usually take patches in this area.
Finally, you should add my Reviewed-by that I provided for the first
resend. Sigh, I have missed that the important people were not in CC.
Best Regards,
Petr
> Christophe
>
> > ---
> >
> > Original patch is here:
> > https://lore.kernel.org/lkml/20190807014417.9418-1-santosh@fossix.org/
> >
> > A similar patch was also sent by Balamuruhan and reviewed by Petr.
> > https://lkml.org/lkml/2020/8/20/1030
> >
> > kernel/watchdog.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> > index 5abb5b22ad13..71109065bd8e 100644
> > --- a/kernel/watchdog.c
> > +++ b/kernel/watchdog.c
> > @@ -44,8 +44,6 @@ int __read_mostly soft_watchdog_user_enabled = 1;
> > int __read_mostly watchdog_thresh = 10;
> > static int __read_mostly nmi_watchdog_available;
> > -static struct cpumask watchdog_allowed_mask __read_mostly;
> > -
> > struct cpumask watchdog_cpumask __read_mostly;
> > unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask);
> > @@ -162,6 +160,8 @@ static void lockup_detector_update_enable(void)
> > int __read_mostly sysctl_softlockup_all_cpu_backtrace;
> > #endif
> > +static struct cpumask watchdog_allowed_mask __read_mostly;
> > +
> > /* Global variables, exported for sysctl */
> > unsigned int __read_mostly softlockup_panic =
> > CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC_VALUE;
> >
prev parent reply other threads:[~2020-11-03 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 9:32 [RESEND PATCH] kernel/watchdog: Fix watchdog_allowed_mask not used warning Santosh Sivaraj
2020-11-03 9:55 ` Christophe Leroy
2020-11-03 10:15 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103101516.GM20201@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bala24@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=santosh@fossix.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).