linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: linuxppc-dev@lists.ozlabs.org
Cc: "Christophe Leroy" <christophe.leroy@c-s.fr>,
	"Ganesh Goudar" <ganeshgr@linux.ibm.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Mahesh Salgaonkar" <mahesh@linux.ibm.com>
Subject: [PATCH v2 02/23] powerpc/pseries/ras: Remove unused variable 'status'
Date: Mon,  4 Jan 2021 15:31:45 +0100	[thread overview]
Message-ID: <20210104143206.695198-3-clg@kaod.org> (raw)
In-Reply-To: <20210104143206.695198-1-clg@kaod.org>

The last use of 'status' was removed in 2012. Remove the variable to
fix this W=1 compile error.

../arch/powerpc/platforms/pseries/ras.c: In function ‘ras_epow_interrupt’:
../arch/powerpc/platforms/pseries/ras.c:318:6: error: variable ‘status’ set but not used [-Werror=unused-but-set-variable]
  318 |  int status;
      |      ^~~~~~

Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
Cc: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Cc: Ganesh Goudar <ganeshgr@linux.ibm.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 arch/powerpc/platforms/pseries/ras.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index 149cec2212e6..bcb614ffce6a 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -315,12 +315,10 @@ static irqreturn_t ras_hotplug_interrupt(int irq, void *dev_id)
 /* Handle environmental and power warning (EPOW) interrupts. */
 static irqreturn_t ras_epow_interrupt(int irq, void *dev_id)
 {
-	int status;
 	int state;
 	int critical;
 
-	status = rtas_get_sensor_fast(EPOW_SENSOR_TOKEN, EPOW_SENSOR_INDEX,
-				      &state);
+	rtas_get_sensor_fast(EPOW_SENSOR_TOKEN, EPOW_SENSOR_INDEX, &state);
 
 	if (state > 3)
 		critical = 1;		/* Time Critical */
@@ -329,12 +327,9 @@ static irqreturn_t ras_epow_interrupt(int irq, void *dev_id)
 
 	spin_lock(&ras_log_buf_lock);
 
-	status = rtas_call(ras_check_exception_token, 6, 1, NULL,
-			   RTAS_VECTOR_EXTERNAL_INTERRUPT,
-			   virq_to_hw(irq),
-			   RTAS_EPOW_WARNING,
-			   critical, __pa(&ras_log_buf),
-				rtas_get_error_log_max());
+	rtas_call(ras_check_exception_token, 6, 1, NULL, RTAS_VECTOR_EXTERNAL_INTERRUPT,
+		  virq_to_hw(irq), RTAS_EPOW_WARNING, critical, __pa(&ras_log_buf),
+		  rtas_get_error_log_max());
 
 	log_error(ras_log_buf, ERR_TYPE_RTAS_LOG, 0);
 
-- 
2.26.2


  parent reply	other threads:[~2021-01-04 14:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 14:31 [PATCH v2 00/23] powerpc: Fix W=1 compile errors Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 01/23] powerpc/mm: Include __find_linux_pte() prototype Cédric Le Goater
2021-01-04 14:31 ` Cédric Le Goater [this message]
2021-01-04 14:31 ` [PATCH v2 03/23] powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 04/23] powerpc/pseries/ras: Make init_ras_hotplug_IRQ() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 05/23] powerpc/pmem: Include pmem prototypes Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 06/23] powerpc/setup_64: Make some routines static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 07/23] powerpc/mce: Include prototypes Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 08/23] powerpc/smp: Include tick_broadcast() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 09/23] powerpc/smp: Make debugger_ipi_callback() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 10/23] powerpc/optprobes: Remove unused routine patch_imm32_load_insns() Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 11/23] powerpc/optprobes: Make patch_imm64_load_insns() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 12/23] powerpc/mm: Declare some prototypes Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 13/23] powerpc/mm: Move hpte_insert_repeating() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 14/23] powerpc/mm: Declare preload_new_slb_context() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 15/23] powerpc/mm/hugetlb: Make pseries_alloc_bootmem_huge_page() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 16/23] powerpc/mm: Declare arch_report_meminfo() prototype Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 17/23] powerpc/watchdog: Declare soft_nmi_interrupt() prototype Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 18/23] KVM: PPC: Make the VMX instruction emulation routines static Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 19/23] KVM: PPC: Book3S HV: Include prototypes Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 20/23] KVM: PPC: Book3S HV: Declare some prototypes Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 21/23] powerpc/pseries: Make IOV setup routines static Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 22/23] powerpc/pcidn: " Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 23/23] powerpc/pseries/eeh: Make pseries_send_allow_unfreeze() static Cédric Le Goater
2021-02-03 11:40 ` [PATCH v2 00/23] powerpc: Fix W=1 compile errors Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104143206.695198-3-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=ganeshgr@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).