From: Michael Walle <michael@walle.cc>
To: linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Saravana Kannan <saravanak@google.com>,
Roy Zang <roy.zang@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Minghuan Lian <minghuan.Lian@nxp.com>,
Michael Walle <michael@walle.cc>,
Bjorn Helgaas <bhelgaas@google.com>,
Mingkai Hu <mingkai.hu@nxp.com>
Subject: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()
Date: Wed, 20 Jan 2021 11:52:46 +0100 [thread overview]
Message-ID: <20210120105246.23218-1-michael@walle.cc> (raw)
fw_devlink will defer the probe until all suppliers are ready. We can't
use builtin_platform_driver_probe() because it doesn't retry after probe
deferral. Convert it to builtin_platform_driver().
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
Signed-off-by: Michael Walle <michael@walle.cc>
---
drivers/pci/controller/dwc/pci-layerscape.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index 44ad34cdc3bc..5b9c625df7b8 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -232,7 +232,7 @@ static const struct of_device_id ls_pcie_of_match[] = {
{ },
};
-static int __init ls_pcie_probe(struct platform_device *pdev)
+static int ls_pcie_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct dw_pcie *pci;
@@ -271,10 +271,11 @@ static int __init ls_pcie_probe(struct platform_device *pdev)
}
static struct platform_driver ls_pcie_driver = {
+ .probe = ls_pcie_probe,
.driver = {
.name = "layerscape-pcie",
.of_match_table = ls_pcie_of_match,
.suppress_bind_attrs = true,
},
};
-builtin_platform_driver_probe(ls_pcie_driver, ls_pcie_probe);
+builtin_platform_driver(ls_pcie_driver);
--
2.20.1
next reply other threads:[~2021-01-20 11:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 10:52 Michael Walle [this message]
2021-01-20 14:23 ` [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() Rob Herring
2021-01-20 14:34 ` Michael Walle
2021-01-20 15:50 ` Greg Kroah-Hartman
2021-01-20 19:02 ` Saravana Kannan
2021-01-20 19:25 ` Michael Walle
2021-01-20 19:28 ` Michael Walle
2021-01-20 19:47 ` Saravana Kannan
2021-01-20 19:47 ` Saravana Kannan
2021-01-20 23:53 ` Michael Walle
2021-01-20 23:58 ` Saravana Kannan
2021-01-21 11:01 ` Geert Uytterhoeven
2021-01-25 19:49 ` Michael Walle
2021-01-25 22:41 ` Saravana Kannan
2021-01-26 8:50 ` Geert Uytterhoeven
2021-01-27 0:44 ` Saravana Kannan
2021-01-27 7:43 ` Geert Uytterhoeven
2021-01-27 16:41 ` Saravana Kannan
2021-01-27 16:56 ` Geert Uytterhoeven
2021-01-27 17:10 ` Saravana Kannan
2021-01-28 9:25 ` Geert Uytterhoeven
2021-01-28 10:35 ` Tony Lindgren
2021-01-28 10:00 ` Tony Lindgren
2021-01-25 16:50 ` Lorenzo Pieralisi
2021-01-25 18:58 ` Saravana Kannan
2021-01-25 19:44 ` Michael Walle
2021-01-26 10:02 ` Lorenzo Pieralisi
2021-01-26 10:39 ` Michael Walle
2021-01-26 10:56 ` Geert Uytterhoeven
2021-01-26 10:55 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120105246.23218-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh@kernel.org \
--cc=roy.zang@nxp.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).