From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70A91C433B4 for ; Tue, 6 Apr 2021 16:51:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A54E9613D0 for ; Tue, 6 Apr 2021 16:51:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A54E9613D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FFD7p1cFlz2yq9 for ; Wed, 7 Apr 2021 02:51:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.215.175; helo=mail-pg1-f175.google.com; envelope-from=mcgrof@gmail.com; receiver=) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FFD7R2WLBz2xgQ for ; Wed, 7 Apr 2021 02:51:13 +1000 (AEST) Received: by mail-pg1-f175.google.com with SMTP id b17so7141766pgh.7 for ; Tue, 06 Apr 2021 09:51:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dUOVVdYoSYbWJM3R8BfH3yp511tJPXM9SJGSE2TL6GY=; b=pDJUlnr8YmDhAW3XqKCZd7gRpqE0ztHxJw0670fxskWdxDR13pfiMn4V3Opb73ch+7 hxVAlF0Zi0B9E462UxesCH5ob75qeA5u1Eklat0X09PoIjaD+/t+PcITtgJ+Tg3ZtDKN NlX7QSxiV9edHzEwPbsnbtEssBlV74xZdS4IAtzWxjKSVqbAU7R57aPjBriCfhLuPLYF RwB6fBF1549yHbUBFV1D+pP16tugbnXdgLXFcdraQwQbYIyc7Ti9X4JT4oZKzwp8/4r6 OchnLtL7FBr2Kub2ALJZAhKdwTr1dgHucrMbggaDNz2oAyaSuwxSrhsM1p95F1udss5w eeCA== X-Gm-Message-State: AOAM531vPdbVbwhtUEha6FxjwZTw7Kq8PL7k01iCcEQ2VDvGsWi6aeaH tcu7Z3GgKnhUstprC4RJmFU= X-Google-Smtp-Source: ABdhPJxJPRbZ8hHR0ZfqHaRIyDYJATSlH01Zbyq90wb+DV+jR9f7adBrfQ3tFv0Oj/c/stWG4JfCFg== X-Received: by 2002:a63:1303:: with SMTP id i3mr27619155pgl.32.1617727870490; Tue, 06 Apr 2021 09:51:10 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id p11sm3129812pjo.48.2021.04.06.09.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 09:51:09 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id AB32F40402; Tue, 6 Apr 2021 16:51:08 +0000 (UTC) Date: Tue, 6 Apr 2021 16:51:08 +0000 From: Luis Chamberlain To: Andy Shevchenko Subject: Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers Message-ID: <20210406165108.GA4332@42.do-not-panic.com> References: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , linux-hyperv@vger.kernel.org, Tetsuo Handa , linux-remoteproc@vger.kernel.org, Michael Kelley , Paul Mackerras , "H. Peter Anvin" , Joel Fernandes , "K. Y. Srinivasan" , Thomas Gleixner , linux-arch@vger.kernel.org, Wei Liu , Stephen Hemminger , Corey Minyard , x86@kernel.org, Ingo Molnar , Iurii Zaikin , Ohad Ben-Cohen , Joerg Roedel , Kees Cook , "Paul E. McKenney" , Lai Jiangshan , Haiyang Zhang , Josh Triplett , "Steven Rostedt \(VMware\)" , rcu@vger.kernel.org, Borislav Petkov , openipmi-developer@lists.sourceforge.net, Bjorn Andersson , Vlastimil Babka , Mathieu Poirier , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Eric Biederman , linux-fsdevel@vger.kernel.org, Mathieu Desnoyers , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h > new file mode 100644 > index 000000000000..41e32483d7a7 > --- /dev/null > +++ b/include/linux/panic_notifier.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_PANIC_NOTIFIERS_H > +#define _LINUX_PANIC_NOTIFIERS_H > + > +#include > +#include > + > +extern struct atomic_notifier_head panic_notifier_list; > + > +extern bool crash_kexec_post_notifiers; > + > +#endif /* _LINUX_PANIC_NOTIFIERS_H */ Why is it worth it to add another file just for this? Seems like a very small file. Luis