From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: devicetree@vger.kernel.org, kbuild-all@lists.01.org,
lkp@intel.com, robh@kernel.org,
Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
bauerman@linux.ibm.com, Daniel Axtens <dja@axtens.net>
Subject: Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()
Date: Fri, 16 Apr 2021 11:09:41 +0300 [thread overview]
Message-ID: <20210416080941.GO6048@kadam> (raw)
In-Reply-To: <f82a9fe2-3254-3f25-616c-10e56103bdc6@csgroup.eu>
On Fri, Apr 16, 2021 at 09:00:12AM +0200, Christophe Leroy wrote:
>
>
> Le 16/04/2021 à 08:44, Daniel Axtens a écrit :
> > Hi Lakshmi,
> >
> > > On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote:
> > >
> > > Sorry - missed copying device-tree and powerpc mailing lists.
> > >
> > > > There are a few "goto out;" statements before the local variable "fdt"
> > > > is initialized through the call to of_kexec_alloc_and_setup_fdt() in
> > > > elf64_load(). This will result in an uninitialized "fdt" being passed
> > > > to kvfree() in this function if there is an error before the call to
> > > > of_kexec_alloc_and_setup_fdt().
> > > >
> > > > Initialize the local variable "fdt" to NULL.
> > > >
> > I'm a huge fan of initialising local variables! But I'm struggling to
> > find the code path that will lead to an uninit fdt being returned...
> >
> > The out label reads in part:
> >
> > /* Make kimage_file_post_load_cleanup free the fdt buffer for us. */
> > return ret ? ERR_PTR(ret) : fdt;
> >
> > As far as I can tell, any time we get a non-zero ret, we're going to
> > return an error pointer rather than the uninitialised value...
>
> I don't think GCC is smart enough to detect that.
>
We disabled uninitialized variable checking for GCC.
But actually is something that has been on my mind recently. Smatch is
supposed to parse this correctly but there is a bug that affects powerpc
and I don't know how to debug it. The kbuild bot is doing cross
platform compiles but I don't have one set up on myself. Could someone
with Smatch installed test something for me?
Or if you don't have Smatch installed then you should definitely install
it. :P
https://www.spinics.net/lists/smatch/msg00568.html
Apply the patch from below and edit the path to point to the correct
directory. Then run kchecker and email me the output?
~/path/to/smatch_scripts/kchecker arch/powerpc/kernel/hw_breakpoint.c
regads,
dan carpenter
diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c
index 8fc7a14e4d71..f2dfba54e14d 100644
--- a/arch/powerpc/kernel/hw_breakpoint.c
+++ b/arch/powerpc/kernel/hw_breakpoint.c
@@ -167,13 +167,19 @@ static bool can_co_exist(struct breakpoint *b, struct perf_event *bp)
return !(alternate_infra_bp(b, bp) && bp_addr_range_overlap(b->bp, bp));
}
+#include "/home/XXX/path/to/smatch/check_debug.h"
static int task_bps_add(struct perf_event *bp)
{
struct breakpoint *tmp;
tmp = alloc_breakpoint(bp);
- if (IS_ERR(tmp))
+ __smatch_about(tmp);
+ __smatch_debug_on();
+ if (IS_ERR(tmp)) {
+ __smatch_debug_off();
+ __smatch_about(tmp);
return PTR_ERR(tmp);
+ }
list_add(&tmp->list, &task_bps);
return 0;
next prev parent reply other threads:[~2021-04-16 8:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210415191437.20212-1-nramas@linux.microsoft.com>
2021-04-15 19:18 ` [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load() Lakshmi Ramasubramanian
2021-04-16 6:44 ` Daniel Axtens
2021-04-16 7:00 ` Christophe Leroy
2021-04-16 8:09 ` Dan Carpenter [this message]
2021-04-16 12:19 ` Michael Ellerman
2021-04-16 7:40 ` Dan Carpenter
2021-04-16 9:05 ` Michael Ellerman
2021-04-16 14:37 ` Lakshmi Ramasubramanian
2021-04-19 23:30 ` Michael Ellerman
2021-04-20 1:33 ` Lakshmi Ramasubramanian
2021-04-20 5:00 ` Dan Carpenter
2021-04-20 5:20 ` Lakshmi Ramasubramanian
2021-04-20 13:06 ` Rob Herring
2021-04-20 14:42 ` Lakshmi Ramasubramanian
2021-04-20 15:04 ` Lakshmi Ramasubramanian
2021-04-20 15:47 ` Rob Herring
2021-04-20 15:55 ` Lakshmi Ramasubramanian
2021-04-22 2:21 ` Daniel Axtens
2021-04-22 8:05 ` David Laight
2021-04-22 9:34 ` Dan Carpenter
2021-04-22 16:54 ` Segher Boessenkool
2021-04-23 13:50 ` Michael Ellerman
2021-04-23 14:42 ` David Laight
2021-04-23 15:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416080941.GO6048@kadam \
--to=dan.carpenter@oracle.com \
--cc=bauerman@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=devicetree@vger.kernel.org \
--cc=dja@axtens.net \
--cc=kbuild-all@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=nramas@linux.microsoft.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).