From: Nathan Lynch <nathanl@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: aik@ozlabs.ru, ajd@linux.ibm.com, tyreld@linux.ibm.com
Subject: [RFC 04/10] powerpc/rtas-rtc: convert set-time-of-day to rtas_sched_if_busy()
Date: Mon, 3 May 2021 22:03:52 -0500 [thread overview]
Message-ID: <20210504030358.1715034-5-nathanl@linux.ibm.com> (raw)
In-Reply-To: <20210504030358.1715034-1-nathanl@linux.ibm.com>
rtas_set_rtc_time() is called only in process context; convert this to
rtas_sched_if_busy().
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
---
arch/powerpc/kernel/rtas-rtc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc/kernel/rtas-rtc.c b/arch/powerpc/kernel/rtas-rtc.c
index 82cb95f29a11..421b92f95669 100644
--- a/arch/powerpc/kernel/rtas-rtc.c
+++ b/arch/powerpc/kernel/rtas-rtc.c
@@ -62,7 +62,7 @@ void rtas_get_rtc_time(struct rtc_time *rtc_tm)
int rtas_set_rtc_time(struct rtc_time *tm)
{
- int error, wait_time;
+ int error;
u64 max_wait_tb;
max_wait_tb = get_tb() + tb_ticks_per_usec * 1000 * MAX_RTC_WAIT;
@@ -72,13 +72,7 @@ int rtas_set_rtc_time(struct rtc_time *tm)
tm->tm_mday, tm->tm_hour, tm->tm_min,
tm->tm_sec, 0);
- wait_time = rtas_busy_delay_time(error);
- if (wait_time) {
- if (in_interrupt())
- return 1; /* probably decrementer */
- msleep(wait_time);
- }
- } while (wait_time && (get_tb() < max_wait_tb));
+ } while (rtas_sched_if_busy(error) && (get_tb() < max_wait_tb));
if (error != 0)
printk_ratelimited(KERN_WARNING
--
2.30.2
next prev parent reply other threads:[~2021-05-04 3:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 3:03 [RFC 00/10] powerpc/rtas: improved busy and extended delay status handling Nathan Lynch
2021-05-04 3:03 ` [RFC 01/10] powerpc/rtas: new APIs for busy and extended delay statuses Nathan Lynch
2021-05-13 9:59 ` Alexey Kardashevskiy
2021-05-04 3:03 ` [RFC 02/10] powerpc/rtas: do not schedule in rtas_os_term() Nathan Lynch
2021-05-04 3:03 ` [RFC 03/10] powerpc/rtas-rtc: convert get-time-of-day to rtas_force_spin_if_busy() Nathan Lynch
2021-05-04 3:03 ` Nathan Lynch [this message]
2021-05-04 3:03 ` [RFC 05/10] powerpc/pseries/fadump: convert to rtas_sched_if_busy() Nathan Lynch
2021-05-04 3:03 ` [RFC 06/10] powerpc/pseries/msi: " Nathan Lynch
2021-05-04 3:03 ` [RFC 07/10] powerpc/pseries/iommu: " Nathan Lynch
2021-05-04 3:03 ` [RFC 08/10] powerpc/pseries/dlpar: " Nathan Lynch
2021-05-04 3:03 ` [RFC 09/10] powerpc/rtas: " Nathan Lynch
2021-05-04 3:03 ` [RFC 10/10] powerpc/rtas_flash: " Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504030358.1715034-5-nathanl@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=ajd@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).