From: Steven Rostedt <rostedt@goodmis.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-arch@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
ryabinin.a.a@gmail.com, arnd@arndb.de,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org, ast@kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
mingo@redhat.com, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [PATCH v2 2/7] kallsyms: Fix address-checks for kernel related range
Date: Wed, 28 Jul 2021 10:46:42 -0400 [thread overview]
Message-ID: <20210728104642.7ae75442@oasis.local.home> (raw)
In-Reply-To: <20210728081320.20394-3-wangkefeng.wang@huawei.com>
On Wed, 28 Jul 2021 16:13:15 +0800
Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> The is_kernel_inittext/is_kernel_text/is_kernel function should not
> include the end address(the labels _einittext, _etext and _end) when
> check the address range, the issue exists since Linux v2.6.12.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Petr Mladek <pmladek@suse.com>
> Acked-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> ---
> include/linux/kallsyms.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h
> index 2a241e3f063f..b016c62f30a6 100644
> --- a/include/linux/kallsyms.h
> +++ b/include/linux/kallsyms.h
> @@ -27,21 +27,21 @@ struct module;
> static inline int is_kernel_inittext(unsigned long addr)
> {
> if (addr >= (unsigned long)_sinittext
> - && addr <= (unsigned long)_einittext)
> + && addr < (unsigned long)_einittext)
> return 1;
> return 0;
> }
>
> static inline int is_kernel_text(unsigned long addr)
> {
> - if ((addr >= (unsigned long)_stext && addr <= (unsigned long)_etext))
> + if ((addr >= (unsigned long)_stext && addr < (unsigned long)_etext))
> return 1;
> return in_gate_area_no_mm(addr);
> }
>
> static inline int is_kernel(unsigned long addr)
> {
> - if (addr >= (unsigned long)_stext && addr <= (unsigned long)_end)
> + if (addr >= (unsigned long)_stext && addr < (unsigned long)_end)
> return 1;
> return in_gate_area_no_mm(addr);
> }
next prev parent reply other threads:[~2021-07-28 14:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 8:13 [PATCH v2 0/7] sections: Unify kernel sections range check and use Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 1/7] kallsyms: Remove arch specific text and data check Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 2/7] kallsyms: Fix address-checks for kernel related range Kefeng Wang
2021-07-28 14:46 ` Steven Rostedt [this message]
2021-07-29 2:03 ` Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 3/7] sections: Move and rename core_kernel_data() to is_kernel_core_data() Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 4/7] sections: Move is_kernel_inittext() into sections.h Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 5/7] kallsyms: Rename is_kernel() and is_kernel_text() Kefeng Wang
2021-07-28 15:28 ` Steven Rostedt
2021-07-29 2:00 ` Kefeng Wang
2021-07-29 4:05 ` Steven Rostedt
2021-07-29 11:06 ` Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 6/7] sections: Add new " Kefeng Wang
2021-07-28 15:32 ` Steven Rostedt
2021-07-29 2:02 ` Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 7/7] powerpc/mm: Use is_kernel_text() and is_kernel_inittext() helper Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728104642.7ae75442@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=pmladek@suse.com \
--cc=ryabinin.a.a@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).